Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2671553003: Remove uses of VisitDOMWrapper (Closed)
Patch Set: Add DependentLifetime when removing Custom=VisitDOMWrapper Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
index 247958978cea2a5563e6c6e13d3fe4bc99620bb8..12a50b00619807d8705d3c6682262657de8a2869 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
@@ -6295,53 +6295,6 @@ Extensions3DUtil* WebGLRenderingContextBase::extensionsUtil() {
return m_extensionsUtil.get();
}
-void WebGLRenderingContextBase::visitChildDOMWrappers(
- v8::Isolate* isolate,
- const v8::Persistent<v8::Object>& wrapper) {
- if (isContextLost()) {
- return;
- }
- DOMWrapperWorld::setWrapperReferencesInAllWorlds(wrapper, m_boundArrayBuffer,
- isolate);
- DOMWrapperWorld::setWrapperReferencesInAllWorlds(
- wrapper, m_renderbufferBinding, isolate);
-
- for (auto& unit : m_textureUnits) {
- DOMWrapperWorld::setWrapperReferencesInAllWorlds(
- wrapper, unit.m_texture2DBinding, isolate);
- DOMWrapperWorld::setWrapperReferencesInAllWorlds(
- wrapper, unit.m_textureCubeMapBinding, isolate);
- DOMWrapperWorld::setWrapperReferencesInAllWorlds(
- wrapper, unit.m_texture3DBinding, isolate);
- DOMWrapperWorld::setWrapperReferencesInAllWorlds(
- wrapper, unit.m_texture2DArrayBinding, isolate);
- }
-
- DOMWrapperWorld::setWrapperReferencesInAllWorlds(
- wrapper, m_framebufferBinding, isolate);
- if (m_framebufferBinding) {
- m_framebufferBinding->visitChildDOMWrappers(isolate, wrapper);
- }
-
- DOMWrapperWorld::setWrapperReferencesInAllWorlds(wrapper, m_currentProgram,
- isolate);
- if (m_currentProgram) {
- m_currentProgram->visitChildDOMWrappers(isolate, wrapper);
- }
-
- DOMWrapperWorld::setWrapperReferencesInAllWorlds(
- wrapper, m_boundVertexArrayObject, isolate);
- if (m_boundVertexArrayObject) {
- m_boundVertexArrayObject->visitChildDOMWrappers(isolate, wrapper);
- }
-
- for (ExtensionTracker* tracker : m_extensions) {
- WebGLExtension* extension = tracker->getExtensionObjectIfAlreadyEnabled();
- DOMWrapperWorld::setWrapperReferencesInAllWorlds(wrapper, extension,
- isolate);
- }
-}
-
void WebGLRenderingContextBase::stop() {
if (!isContextLost()) {
// Never attempt to restore the context because the page is being torn down.

Powered by Google App Engine
This is Rietveld 408576698