third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h - Issue 2671553003: Remove uses of VisitDOMWrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

Issue 2671553003: Remove uses of VisitDOMWrapper (Closed)

Patch Set: Add DependentLifetime when removing Custom=VisitDOMWrapper Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

index 227026cccaa3fb9b5a7e8c6682c1cad0a5019530..cc970e70ecff0d9c37674b30f0c53cc4075e405e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

@@ -154,11 +154,6 @@ class CORE_EXPORT ScriptWrappable : public TraceWrapperBase {

return containsWrapper();

}

- void setReference(const v8::Persistent<v8::Object>& parent,

- v8::Isolate* isolate) {

- isolate->SetReference(parent, m_mainWorldWrapper);

- }

bool containsWrapper() const { return !m_mainWorldWrapper.IsEmpty(); }

// Mark wrapper of this ScriptWrappable as alive in V8. Only marks