third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp - Issue 2671553003: Remove uses of VisitDOMWrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

Issue 2671553003: Remove uses of VisitDOMWrapper (Closed)

Patch Set: Add DependentLifetime when removing Custom=VisitDOMWrapper Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

index e4e7bcd0dad5071bcbf66284ad842fc88898342e..c081df8123c1c9a0d7eae3f0ef0e016ea0d1a4c9 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

@@ -531,15 +531,6 @@ GLenum WebGLFramebuffer::getDrawBuffer(GLenum drawBuffer) {

return GL_NONE;

}

-void WebGLFramebuffer::visitChildDOMWrappers(

- v8::Isolate* isolate,

- const v8::Persistent<v8::Object>& wrapper) {

- for (const auto& attachment : m_attachments) {

- DOMWrapperWorld::setWrapperReferencesInAllWorlds(

- wrapper, attachment.value->object(), isolate);

- }

DEFINE_TRACE(WebGLFramebuffer) {

visitor->trace(m_attachments);

WebGLContextObject::trace(visitor);