Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h

Issue 2671553003: Remove uses of VisitDOMWrapper (Closed)
Patch Set: Add DependentLifetime when removing Custom=VisitDOMWrapper Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h b/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
index 272c55149e824c63d1a9f82d6811b3eff2cae980..7a062392da6560982d1c259fa5e59b07827bc327 100644
--- a/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
+++ b/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
@@ -117,23 +117,6 @@ class DOMDataStore {
return current(isolate).get(ScriptWrappable::fromNode(node), isolate);
}
- static void setWrapperReference(const v8::Persistent<v8::Object>& parent,
- ScriptWrappable* child,
- v8::Isolate* isolate) {
- current(isolate).setReference(parent, child, isolate);
- }
-
- static void setWrapperReference(const v8::Persistent<v8::Object>& parent,
- Node* child,
- v8::Isolate* isolate) {
- if (canUseScriptWrappable(child)) {
- ScriptWrappable::fromNode(child)->setReference(parent, isolate);
- return;
- }
- current(isolate).setReference(parent, ScriptWrappable::fromNode(child),
- isolate);
- }
-
// Associates the given |object| with the given |wrapper| if the object is
// not yet associated with any wrapper. Returns true if the given wrapper
// is associated with the object, or false if the object is already
@@ -173,16 +156,6 @@ class DOMDataStore {
m_wrapperMap->markWrapper(scriptWrappable);
}
- void setReference(const v8::Persistent<v8::Object>& parent,
- ScriptWrappable* child,
- v8::Isolate* isolate) {
- if (m_isMainWorld) {
- child->setReference(parent, isolate);
- return;
- }
- m_wrapperMap->setReference(isolate, parent, child);
- }
-
bool setReturnValueFrom(v8::ReturnValue<v8::Value> returnValue,
ScriptWrappable* object) {
if (m_isMainWorld)
« no previous file with comments | « third_party/WebKit/Source/bindings/bindings.gni ('k') | third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698