Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2671553003: Remove uses of VisitDOMWrapper (Closed)
Patch Set: Add DependentLifetime when removing Custom=VisitDOMWrapper Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
index c72c8e23aeca3741dcc44a9b2aca44de74704ff7..4d31c37fbb668742d0bbf72e09a8e1efd776748d 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
@@ -235,12 +235,7 @@ def interface_context(interface, interfaces):
}
set_wrapper_reference_to['idl_type'].add_includes_for_type()
- # [Custom=VisitDOMWrapper]
- has_visit_dom_wrapper_custom = (
- has_extended_attribute_value(interface, 'Custom', 'VisitDOMWrapper'))
-
- has_visit_dom_wrapper = (has_visit_dom_wrapper_custom or
- set_wrapper_reference_from or set_wrapper_reference_to)
+ has_visit_dom_wrapper = (set_wrapper_reference_from or set_wrapper_reference_to)
wrapper_class_id = ('NodeClassId' if inherits_interface(interface.name, 'Node') else 'ObjectClassId')
@@ -269,7 +264,6 @@ def interface_context(interface, interfaces):
'has_custom_legacy_call_as_function': has_extended_attribute_value(interface, 'Custom', 'LegacyCallAsFunction'), # [Custom=LegacyCallAsFunction]
'has_partial_interface': len(interface.partial_interfaces) > 0,
'has_visit_dom_wrapper': has_visit_dom_wrapper,
- 'has_visit_dom_wrapper_custom': has_visit_dom_wrapper_custom,
'header_includes': header_includes,
'interface_name': interface.name,
'is_array_buffer_or_view': is_array_buffer_or_view,

Powered by Google App Engine
This is Rietveld 408576698