Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

Explicitly specify DependentLifetime for types that used either
SetWrapperReferenceTo or SetWrapperReferenceFrom.

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2676663006
Cr-Commit-Position: refs/heads/master@{#448320}
Committed: https://chromium.googlesource.com/chromium/src/+/6bd797e0cc89fa16ea640a98b600409fa56984cf

[Michael Lippautz, 2017-02-03 23:49:10]

Description was changed from

==========
Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

BUG=
==========

to

==========
Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

BUG=chromium:682688
==========

[Michael Lippautz, 2017-02-04 00:50:37]

Description was changed from

==========
Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

BUG=chromium:682688
==========

to

==========
Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Michael Lippautz, 2017-02-04 00:51:06]

Description was changed from

==========
Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Michael Lippautz, 2017-02-04 00:58:37]

Description was changed from

==========
Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

Explicitly specifies DependentLifetime for types that used either
SetWrapperReferenceTo or SetWrapperReferenceFrom

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Michael Lippautz, 2017-02-04 00:59:16]

Description was changed from

==========
Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

Explicitly specifies DependentLifetime for types that used either
SetWrapperReferenceTo or SetWrapperReferenceFrom

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

Explicitly specify DependentLifetime for types that used either
SetWrapperReferenceTo or SetWrapperReferenceFrom.

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Michael Lippautz, 2017-02-04 01:19:08]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 01:19:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Lippautz, 2017-02-04 02:29:32]

Description was changed from

==========
Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

Explicitly specify DependentLifetime for types that used either
SetWrapperReferenceTo or SetWrapperReferenceFrom.

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

Explicitly specify DependentLifetime for types that used either
SetWrapperReferenceTo or SetWrapperReferenceFrom.

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Michael Lippautz, 2017-02-04 02:29:33]

mlippautz@chromium.org changed reviewers:
+ haraken@chromium.org, jochen@chromium.org

[Michael Lippautz, 2017-02-04 02:29:45]

ptal \o/

[commit-bot: I haz the power, 2017-02-04 05:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 05:34:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Michael Lippautz, 2017-02-04 05:58:34]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 05:58:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 07:59:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 07:59:12]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)

[haraken, 2017-02-04 09:25:33]

LGTM

However, I'm a bit afraid that developers will easily miss adding
[DependentLifetime] to those DOM objects... We need to implement some
verification for it.

Can we introduce a DCHECK that verifies that DOM objects traced by
TRACE_WRAPPERS are marked as [DependentLifetime]? A follow-up CL is fine.

Or do you have any idea on removing [DependentLifetime] entirely? (i.e., let the
IDL compiler or V8 understand if a given object is a dependent object or not)

[jochen (gone - plz use gerrit), 2017-02-04 18:13:41]

lgtm

[Michael Lippautz, 2017-02-04 18:31:13]

On 2017/02/04 09:25:33, haraken wrote:
> LGTM
> 
> However, I'm a bit afraid that developers will easily miss adding
> [DependentLifetime] to those DOM objects... We need to implement some
> verification for it.
> 
> Can we introduce a DCHECK that verifies that DOM objects traced by
> TRACE_WRAPPERS are marked as [DependentLifetime]? A follow-up CL is fine.
> 

Good point! I added the DCHECK already to traceWrappers on the WrapperTypeInfo.
That should flush out any issues.

> Or do you have any idea on removing [DependentLifetime] entirely? (i.e., let
the
> IDL compiler or V8 understand if a given object is a dependent object or not)

My takeaway from the conversations at blinkon is that it is even hard by reading
the spec :) Not sure the compiler could figure that out.

[Michael Lippautz, 2017-02-04 18:31:27]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 18:31:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 20:01:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 20:01:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Michael Lippautz, 2017-02-06 17:19:04]

On 2017/02/04 18:31:13, Michael Lippautz (slow travel) wrote:
> On 2017/02/04 09:25:33, haraken wrote:
> > LGTM
> > 
> > However, I'm a bit afraid that developers will easily miss adding
> > [DependentLifetime] to those DOM objects... We need to implement some
> > verification for it.
> > 
> > Can we introduce a DCHECK that verifies that DOM objects traced by
> > TRACE_WRAPPERS are marked as [DependentLifetime]? A follow-up CL is fine.
> > 
> 
> Good point! I added the DCHECK already to traceWrappers on the
WrapperTypeInfo.
> That should flush out any 

The DCHECK flushed out some smaller issues, that are already present on tip of
tree. E.g. DOMWindow not being marked as Dependent. In practice this one
shouldn't be a problem though.

I decided that I want to keep this CL purely mechanical, and then add the DCHECK
and the fixes in a smaller CL.

[Michael Lippautz, 2017-02-06 17:19:16]

Patchset #4 (id:60001) has been deleted

[Michael Lippautz, 2017-02-06 17:19:28]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2017-02-06 17:20:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 18:40:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486401568193500,
"parent_rev": "d3ec68513c6927ccd879502a1b7a7e8685e95838", "commit_rev":
"6bd797e0cc89fa16ea640a98b600409fa56984cf"}

[commit-bot: I haz the power, 2017-02-06 18:41:25]

Description was changed from

==========
Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

Explicitly specify DependentLifetime for types that used either
SetWrapperReferenceTo or SetWrapperReferenceFrom.

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove SetWrapperReferenceTo and SetWrapperReferenceFrom

Explicitly specify DependentLifetime for types that used either
SetWrapperReferenceTo or SetWrapperReferenceFrom.

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2676663006
Cr-Commit-Position: refs/heads/master@{#448320}
Committed:
https://chromium.googlesource.com/chromium/src/+/6bd797e0cc89fa16ea640a98b600...
==========

[commit-bot: I haz the power, 2017-02-06 18:41:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6bd797e0cc89fa16ea640a98b600...