third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h - Issue 2671553003: Remove uses of VisitDOMWrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Issue 2671553003: Remove uses of VisitDOMWrapper (Closed)

Patch Set: Add DependentLifetime when removing Custom=VisitDOMWrapper Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.idl ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

index bb7392ec15658fc1e330f6ad7c87f972877e60fb..633d2a89386a26c22ea11ab9c8a3dbacc7454525 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

@@ -603,8 +603,6 @@ class MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext,

friend class ScopedDrawingBufferBinder;

friend class ScopedTexture2DRestorer;

friend class ScopedFramebufferRestorer;

- // To allow V8WebGL[2]RenderingContext to call visitChildDOMWrappers.

- friend class V8WebGLRenderingContext;

friend class ScopedUnpackParametersResetRestore;

WebGLRenderingContextBase(HTMLCanvasElement*,

@@ -666,9 +664,6 @@ class MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext,

// Restore the client unpack parameters.

virtual void restoreUnpackParameters();

- virtual void visitChildDOMWrappers(v8::Isolate*,

- const v8::Persistent<v8::Object>&);

PassRefPtr<Image> drawImageIntoBuffer(PassRefPtr<Image>,

int width,

int height,