ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm - Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm ('k') | ios/chrome/browser/ui/stack_view/card_view.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm

diff --git a/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm b/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm

index 2ccd5b3a866962d4e5e446f532475be2280286a9..9744b78e7ebe0f51267dc19576815c86590770c8 100644

--- a/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm

+++ b/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm

@@ -8,7 +8,7 @@

#include "base/i18n/time_formatting.h"

#include "base/mac/foundation_util.h"

-#import "base/mac/objc_property_releaser.h"

+#import "base/mac/objc_release_properties.h"

#import "base/mac/scoped_nsobject.h"

#include "base/strings/sys_string_conversions.h"

#include "components/browser_sync/profile_sync_service.h"

@@ -65,8 +65,6 @@ const CGFloat kSpinnerButtonPadding = 18;

std::unique_ptr<SyncObserverBridge> syncObserver_;

std::unique_ptr<OAuth2TokenServiceObserverBridge> tokenServiceObserver_;

base::scoped_nsobject<UITextField> passphrase_;

- base::mac::ObjCPropertyReleaser

- propertyReleaser_SyncEncryptionPassphraseCollectionViewController_;

}

// Sets up the navigation bar's right button. The button will be enabled iff

@@ -142,14 +140,16 @@ const CGFloat kSpinnerButtonPadding = 18;

tokenServiceObserver_.reset(new OAuth2TokenServiceObserverBridge(

OAuth2TokenServiceFactory::GetForBrowserState(browserState_), self));

- propertyReleaser_SyncEncryptionPassphraseCollectionViewController_.Init(

- self, [SyncEncryptionPassphraseCollectionViewController class]);

[self loadModel];

}

return self;

}

+- (void)dealloc {

+ base::mac::ReleaseProperties(self);

+ [super dealloc];

- (UITextField*)passphrase {

return passphrase_;

}