Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: ios/chrome/browser/ui/stack_view/card_view.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/stack_view/card_view.mm
diff --git a/ios/chrome/browser/ui/stack_view/card_view.mm b/ios/chrome/browser/ui/stack_view/card_view.mm
index 0ca24d4c40d7edd9d0520efe319fe27cd32f2a07..62a810a524db666daa48ad36ee382e73dcb09c0b 100644
--- a/ios/chrome/browser/ui/stack_view/card_view.mm
+++ b/ios/chrome/browser/ui/stack_view/card_view.mm
@@ -26,7 +26,7 @@
#include <algorithm>
#import "base/mac/foundation_util.h"
-#import "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#import "base/mac/scoped_nsobject.h"
#include "components/strings/grit/components_strings.h"
#import "ios/chrome/browser/ui/animation_util.h"
@@ -124,9 +124,7 @@ UIImage* ImageWithName(NSString* image_name, BOOL is_incognito) {
@end
-@implementation CardTabView {
- base::mac::ObjCPropertyReleaser _propertyReleaser_CardTabView;
-}
+@implementation CardTabView
#pragma mark - Property Implementation
@@ -146,7 +144,6 @@ UIImage* ImageWithName(NSString* image_name, BOOL is_incognito) {
if (!self)
return self;
- _propertyReleaser_CardTabView.Init(self, [CardTabView class]);
_isIncognito = isIncognito;
UIImage* image = ImageWithName(@"default_favicon", _isIncognito);
@@ -178,6 +175,11 @@ UIImage* ImageWithName(NSString* image_name, BOOL is_incognito) {
return nil;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)setCloseButtonSide:(CardCloseButtonSide)closeButtonSide {
if (_closeButtonSide != closeButtonSide) {
_closeButtonSide = closeButtonSide;

Powered by Google App Engine
This is Rietveld 408576698