ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm - Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/popup_menu/popup_menu_controller.mm ('k') | ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm

diff --git a/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm b/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm

index 742b1c7ba7c18760938259d0b7d1651cc1dcad8f..54759967257ab4ed06f541d54a33445d6ce1efae 100644

--- a/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm

+++ b/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm

@@ -11,7 +11,7 @@

#import "base/ios/weak_nsobject.h"

#include "base/logging.h"

#include "base/mac/foundation_util.h"

-#import "base/mac/objc_property_releaser.h"

+#import "base/mac/objc_release_properties.h"

#import "base/mac/scoped_nsobject.h"

#include "base/memory/ptr_util.h"

#include "base/numerics/safe_conversions.h"

@@ -162,9 +162,6 @@ void SavePasswordsConsumer::OnGetPasswordStoreResults(

// Module containing the reauthentication mechanism for viewing and copying

// passwords.

base::scoped_nsobject<ReauthenticationModule> reauthenticationModule_;

- base::mac::ObjCPropertyReleaser

- propertyReleaser_SavePasswordsCollectionViewController_;

}

// Kick off async request to get logins from password store.

- (void)getLoginsFromPasswordStore;

@@ -194,15 +191,13 @@ void SavePasswordsConsumer::OnGetPasswordStoreResults(

[self getLoginsFromPasswordStore];

[self updateEditButton];

[self loadModel];

- propertyReleaser_SavePasswordsCollectionViewController_.Init(

- self, [SavePasswordsCollectionViewController class]);

}

return self;

}

- (void)dealloc {

[passwordManagerEnabled_ setObserver:nil];

+ base::mac::ReleaseProperties(self);

[super dealloc];

}