Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

ios/chrome/browser/ui/history/history_entry_item.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/history/history_entry_item.h"
 
 #include "base/i18n/time_formatting.h"
 #include "base/ios/weak_nsobject.h"
 #import "base/mac/foundation_util.h"
-#import "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/history/core/browser/url_row.h"
 #include "components/strings/grit/components_strings.h"
 #include "components/url_formatter/url_formatter.h"
 #include "ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h"
 #import "ios/chrome/browser/ui/history/favicon_view.h"
 #import "ios/chrome/browser/ui/history/favicon_view_provider.h"
 #import "ios/chrome/browser/ui/history/history_entry.h"
 #include "ios/chrome/browser/ui/rtl_geometry.h"
@@ skipping 31 matching lines @@
     else
       base::i18n::AdjustStringForLocaleDirection(&formatted_title);
   }
   return base::SysUTF16ToNSString(formatted_title);
 }
 }  // namespace
 
 #pragma mark - HistoryEntryItem
 
 @interface HistoryEntryItem ()<FaviconViewProviderDelegate> {
-  // Property releaser for HistoryEntryItem.
-  base::mac::ObjCPropertyReleaser _propertyReleaser_HistoryEntryItem;
   // Delegate for HistoryEntryItem.
   base::WeakNSProtocol<id<HistoryEntryItemDelegate>> _delegate;
 }
 
 // FaviconViewProvider to fetch the favicon and format the favicon view.
 @property(nonatomic, retain) FaviconViewProvider* faviconViewProvider;
 
 // Custom accessibility actions for the history entry view.
 - (NSArray*)accessibilityActions;
 // Custom accessibility action to delete the history entry.
@@ skipping 15 matching lines @@
 @synthesize timeText = _timeText;
 @synthesize URL = _URL;
 @synthesize timestamp = _timestamp;
 
 - (instancetype)initWithType:(NSInteger)type
                 historyEntry:(const history::HistoryEntry&)entry
                 browserState:(ios::ChromeBrowserState*)browserState
                     delegate:(id<HistoryEntryItemDelegate>)delegate {
   self = [super initWithType:type];
   if (self) {
-    _propertyReleaser_HistoryEntryItem.Init(self, [HistoryEntryItem class]);
     self.cellClass = [HistoryEntryCell class];
     favicon::LargeIconService* largeIconService =
         IOSChromeLargeIconServiceFactory::GetForBrowserState(browserState);
     _faviconViewProvider =
         [[FaviconViewProvider alloc] initWithURL:entry.url
                                      faviconSize:kFaviconSize
                                   minFaviconSize:kMinFaviconSize
                                 largeIconService:largeIconService
                                         delegate:self];
     _text = [FormattedTitle(entry.title, entry.url) copy];
     _detailText = [base::SysUTF8ToNSString(entry.url.spec()) copy];
     _timeText =
         [base::SysUTF16ToNSString(base::TimeFormatTimeOfDay(entry.time)) copy];
     _URL = GURL(entry.url);
     _timestamp = entry.time;
     _delegate.reset(delegate);
   }
   return self;
 }
 
+- (void)dealloc {
+  base::mac::ReleaseProperties(self);
+  [super dealloc];
+}
+
 - (instancetype)initWithType:(NSInteger)type {
   NOTREACHED();
   return nil;
 }
 
 - (BOOL)isEqualToHistoryEntryItem:(HistoryEntryItem*)item {
   return item && item.URL == _URL && item.timestamp == _timestamp;
 }
 
 - (BOOL)isEqual:(id)object {
@@ skipping 83 matching lines @@
 }
 
 - (void)faviconViewProviderFaviconDidLoad:(FaviconViewProvider*)provider {
   [_delegate historyEntryItemShouldUpdateView:self];
 }
 
 @end
 
 #pragma mark - HistoryEntryCell
 
-@interface HistoryEntryCell () {
-  // Property releaser for HistoryEntryCell.
-  base::mac::ObjCPropertyReleaser _propertyReleaser_HistoryEntryCell;
-}
-
-// Redeclare as readwrite to allow property releaser to handle these properties.
-@property(nonatomic, readwrite, retain) UILabel* textLabel;
-@property(nonatomic, readwrite, retain) UILabel* detailTextLabel;
-@property(nonatomic, readwrite, retain) UILabel* timeLabel;

[Sidney San Martín, 2017/01/05 03:24:05]

This pattern of redeclaring properties as readwrite shows up in a few places. I
don't think it's necessary with the new implementation, but I added a test to
make sure.

[noyau (Ping after 24h), 2017/01/05 10:02:52]

At some point the property releaser had a bug (inherited from the objc runtime)
where readonly properties were not enumerated properly, and as such not released
by the property releaser. Redeclaration for those is no longer necessary.

But there are some cases where the public API is a readonly property, but from
within the class itself it is redeclared as readwrite for cleaner code. Those
need to stay as the code would not compile without it. 

-@end
-
 @implementation HistoryEntryCell
 
 @synthesize faviconViewContainer = _faviconViewContainer;
 @synthesize textLabel = _textLabel;
 @synthesize detailTextLabel = _detailTextLabel;
 @synthesize timeLabel = _timeLabel;
 
 - (id)initWithFrame:(CGRect)frame {
   self = [super initWithFrame:frame];
   if (self) {
-    _propertyReleaser_HistoryEntryCell.Init(self, [HistoryEntryCell class]);
-
     _faviconViewContainer = [[UIView alloc] initWithFrame:CGRectZero];
 
     _textLabel = [[UILabel alloc] initWithFrame:CGRectZero];
     [_textLabel
         setFont:[[MDFRobotoFontLoader sharedInstance] mediumFontOfSize:16]];
     [_textLabel setTextColor:[[MDCPalette greyPalette] tint900]];
 
     _detailTextLabel = [[UILabel alloc] initWithFrame:CGRectZero];
     [_detailTextLabel
         setFont:[[MDFRobotoFontLoader sharedInstance] regularFontOfSize:14]];
@@ skipping 39 matching lines @@
     AddSameCenterYConstraint(_faviconViewContainer, _textLabel);
 
     [_timeLabel
         setContentCompressionResistancePriority:UILayoutPriorityRequired
                                         forAxis:
                                             UILayoutConstraintAxisHorizontal];
   }
   return self;
 }
 
+- (void)dealloc {
+  base::mac::ReleaseProperties(self);
+  [super dealloc];
+}
+
 - (void)prepareForReuse {
   [super prepareForReuse];
   _textLabel.text = nil;
   _detailTextLabel.text = nil;
   _timeLabel.text = nil;
   for (UIView* subview in _faviconViewContainer.subviews) {
     [subview removeFromSuperview];
   }
 }
 
 @end