Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
diff --git a/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm b/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
index 9db0a61675baa70ebb7f58b333dc722caa7d342d..182983a755e020df31c48d51793426f09d957416 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
+++ b/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm
@@ -5,7 +5,7 @@
#import "ios/chrome/browser/ui/tools_menu/tools_menu_view_item.h"
#include "base/i18n/rtl.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#import "ios/third_party/material_roboto_font_loader_ios/src/src/MaterialRobotoFontLoader.h"
#include "ui/base/l10n/l10n_util.h"
@@ -16,9 +16,7 @@ const CGFloat kToolsMenuItemHorizontalMarginRTL = 25;
static NSString* const kMenuItemCellID = @"MenuItemCellID";
}
-@implementation ToolsMenuViewItem {
- base::mac::ObjCPropertyReleaser _propertyReleaser_ToolsMenuViewItem;
-}
+@implementation ToolsMenuViewItem
@synthesize accessibilityIdentifier = _accessibilityIdentifier;
@synthesize active = _active;
@@ -29,13 +27,17 @@ static NSString* const kMenuItemCellID = @"MenuItemCellID";
- (id)init {
self = [super init];
if (self) {
- _propertyReleaser_ToolsMenuViewItem.Init(self, [ToolsMenuViewItem class]);
_active = YES;
}
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
+ (NSString*)cellID {
return kMenuItemCellID;
}
@@ -58,9 +60,7 @@ static NSString* const kMenuItemCellID = @"MenuItemCellID";
@end
-@implementation ToolsMenuViewCell {
- base::mac::ObjCPropertyReleaser _propertyReleaser_ToolsMenuViewCell;
-}
+@implementation ToolsMenuViewCell
@synthesize title = _title;
@synthesize horizontalMargin = _horizontalMargin;
@@ -82,13 +82,17 @@ static NSString* const kMenuItemCellID = @"MenuItemCellID";
}
- (void)commonInitialization {
- _propertyReleaser_ToolsMenuViewCell.Init(self, [ToolsMenuViewCell class]);
_horizontalMargin = !base::i18n::IsRTL() ? kToolsMenuItemHorizontalMargin
: kToolsMenuItemHorizontalMarginRTL;
[self setBackgroundColor:[UIColor whiteColor]];
[self setOpaque:YES];
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)prepareForReuse {
[super prepareForReuse];
[_title setText:nil];

Powered by Google App Engine
This is Rietveld 408576698