Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: ios/chrome/browser/ui/authentication/authentication_flow.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/authentication/authentication_flow.mm
diff --git a/ios/chrome/browser/ui/authentication/authentication_flow.mm b/ios/chrome/browser/ui/authentication/authentication_flow.mm
index ca6c1dddd09746f0a6c8d280449f9e6787877ae0..f00b3dca3d00a1efc68fd47a3474abfd43a5ce73 100644
--- a/ios/chrome/browser/ui/authentication/authentication_flow.mm
+++ b/ios/chrome/browser/ui/authentication/authentication_flow.mm
@@ -6,7 +6,7 @@
#include "base/ios/weak_nsobject.h"
#include "base/logging.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_block.h"
#include "base/mac/scoped_nsobject.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state.h"
@@ -101,8 +101,6 @@ NSError* IdentityMissingError() {
// is in progress to ensure it outlives any attempt to destroy it in
// |_signInCompletion|.
base::scoped_nsobject<AuthenticationFlow> _selfRetainer;
-
- base::mac::ObjCPropertyReleaser _propertyReleaser_AuthenticationFlow;
}
@synthesize handlingError = _handlingError;
@@ -124,11 +122,15 @@ NSError* IdentityMissingError() {
_postSignInAction = postSignInAction;
_presentingViewController.reset([presentingViewController retain]);
_state = BEGIN;
- _propertyReleaser_AuthenticationFlow.Init(self, [AuthenticationFlow class]);
}
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)startSignInWithCompletion:(CompletionCallback)completion {
DCHECK_EQ(BEGIN, _state);
DCHECK(!_signInCompletion);
« no previous file with comments | « ios/chrome/browser/snapshots/snapshot_cache.mm ('k') | ios/chrome/browser/ui/elements/activity_overlay_coordinator.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698