chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm - Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm

diff --git a/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm b/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm

index c333a964046237c7926263404a5a89b43f96c863..6670567fce959fe197ef0ff562b7470c45f5478d 100644

--- a/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm

+++ b/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm

@@ -8,6 +8,7 @@

#include "base/bind.h"

#include "base/mac/bundle_locations.h"

+#include "base/mac/objc_release_properties.h"

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

#include "base/metrics/histogram_macros.h"

@@ -601,7 +602,6 @@ class ToolbarActionsBarObserverHelper : public ToolbarActionsBarObserver {

- (id)initWithController:(AppMenuController*)controller {

if ((self = [super initWithNibName:@"AppMenu"

bundle:base::mac::FrameworkBundle()])) {

- propertyReleaser_.Init(self, [AppMenuButtonViewController class]);

controller_ = controller;

[[NSNotificationCenter defaultCenter]

addObserver:self

@@ -614,6 +614,7 @@ class ToolbarActionsBarObserverHelper : public ToolbarActionsBarObserver {

- (void)dealloc {

[[NSNotificationCenter defaultCenter] removeObserver:self];

+ base::mac::ReleaseProperties(self);

[super dealloc];

}