Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

ios/chrome/browser/payments/payment_request_coordinator.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/payments/payment_request_coordinator.h"
 
 #include <unordered_set>
 #include <vector>
 
 #import "base/ios/weak_nsobject.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_data_util.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/credit_card.h"
 #include "components/autofill/core/browser/field_types.h"
 #include "components/autofill/core/browser/personal_data_manager.h"
 #include "ios/chrome/browser/application_context.h"
 #include "ios/chrome/browser/payments/payment_request.h"
 #include "ios/chrome/browser/payments/payment_request_utils.h"
 
 @interface PaymentRequestCoordinator () {
   base::WeakNSProtocol<id<PaymentRequestCoordinatorDelegate>> _delegate;
   base::scoped_nsobject<UINavigationController> _navigationController;
   base::scoped_nsobject<PaymentRequestViewController> _viewController;
   base::scoped_nsobject<PaymentItemsDisplayCoordinator>
       _itemsDisplayCoordinator;
   base::scoped_nsobject<ShippingAddressSelectionCoordinator>
       _shippingAddressSelectionCoordinator;
   base::scoped_nsobject<ShippingOptionSelectionCoordinator>
       _shippingOptionSelectionCoordinator;
   base::scoped_nsobject<PaymentMethodSelectionCoordinator>
       _methodSelectionCoordinator;
-
-  base::mac::ObjCPropertyReleaser _propertyReleaser_PaymentRequestCoordinator;
 }
 
 @end
 
 @implementation PaymentRequestCoordinator
 
 @synthesize paymentRequest = _paymentRequest;
 @synthesize pageFavicon = _pageFavicon;
 @synthesize pageTitle = _pageTitle;
 @synthesize pageHost = _pageHost;
 
 - (instancetype)initWithBaseViewController:
     (UIViewController*)baseViewController {
   if ((self = [super initWithBaseViewController:baseViewController])) {

[sdefresne, 2017/02/14 16:34:26]

Looks like this is now just calling super -initWithBaseViewController:, so maybe
remove?

[Sidney San Martín, 2017/02/14 21:38:15]

Done, thanks. When I initially tried to remove this, I got a diagnostic from
-Wobjc-designated-initializers. I could've sworn I saw other examples of empty
init overrides in the iOS codebase, so I left it. However, I now think that's
just because it's redeclared in payment_request_coordinator.h. I deleted it, but
I'm not sure if the comment in the .h was worth preserving. What do you think?

-    _propertyReleaser_PaymentRequestCoordinator.Init(
-        self, [PaymentRequestCoordinator class]);
   }
   return self;
 }
 
+- (void)dealloc {
+  base::mac::ReleaseProperties(self);
+  [super dealloc];
+}
+
 - (id<PaymentRequestCoordinatorDelegate>)delegate {
   return _delegate.get();
 }
 
 - (void)setDelegate:(id<PaymentRequestCoordinatorDelegate>)delegate {
   _delegate.reset(delegate);
 }
 
 - (void)start {
   _viewController.reset([[PaymentRequestViewController alloc]
@@ skipping 190 matching lines @@
   _methodSelectionCoordinator.reset();
 }
 
 - (void)paymentMethodSelectionCoordinatorDidReturn:
     (PaymentMethodSelectionCoordinator*)coordinator {
   [_methodSelectionCoordinator stop];
   _methodSelectionCoordinator.reset();
 }
 
 @end