Clean up names and remove unnecessary parameter

Clean up names and remove unnecessary parameter

is_non_ime_change and from_non_ime are difficult to understand - it's
negative and the meaning of non-ime change and from non-ime are unclear.
Also, !is_non_ime_change is a double negative and can be very confusing.

Replace these names by reply_to_request.
Also, reply_to_request is currently set only in
RenderWidget::OnRequestTextInputStateUpdate(). By having it call an internal
function, we can remove the parameter from all the other call sites.

Moreover, HIDE_IME is incorrectly named - it does not hide virtual keyboard.

And SHOW_IME and showImeIfNeeded() are mildly confusing - it may sound as
if it affected hardware keyboard but it is actually only concerned with
virtual keyboard. "IfNeeded" was added to stress the point that it only
affects virtual keyboard case. ImeOnFocusTest.cpp is easier to read after
this change.

By adding another function ShowVirtualKeyboard(), the call sites no longer
need to pass a parameter.

Note that showImeIfNeeded() and show_ime_if_needed in the message and
browser process have not changed yet. There are up to 100 files that
are affected, so I will separate them out as a single-themed change.

BUG=662279
Review-Url: https://codereview.chromium.org/2596193002
Cr-Commit-Position: refs/heads/master@{#443836}
Committed: https://chromium.googlesource.com/chromium/src/+/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae

[Changwan Ryu, 2016-12-22 10:21:09]

The CQ bit was checked by changwan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 10:21:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 11:42:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 11:42:54]

Dry run: This issue passed the CQ dry run.

[Changwan Ryu, 2016-12-26 01:14:32]

changwan@chromium.org changed reviewers:
+ aelias@chromium.org

[Changwan Ryu, 2016-12-28 06:20:14]

I realized that FROM_IME may still be useful if we want to update text input
state in the middle of batch edit for changes coming from non ime, e.g. touch
event. WDYT?

[Changwan Ryu, 2016-12-29 06:11:41]

On 2016/12/28 06:20:14, Changwan Ryu wrote:
> I realized that FROM_IME may still be useful if we want to update text input
> state in the middle of batch edit for changes coming from non ime, e.g. touch
> event. WDYT?

I just checked EditText behavior using RemoteIME, and it seems that EditText
does not update text input state
even when there is an external change. Please ignore my previous message.

[Changwan Ryu, 2016-12-29 06:29:19]

The CQ bit was checked by changwan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 06:29:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 07:32:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 07:32:35]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Changwan Ryu, 2017-01-02 00:29:05]

The CQ bit was checked by changwan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-02 00:29:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-02 01:17:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-02 01:17:28]

Dry run: This issue passed the CQ dry run.

[aelias_OOO_until_Jul13, 2017-01-04 00:59:51]

https://codereview.chromium.org/2596193002/diff/40001/content/renderer/render...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/2596193002/diff/40001/content/renderer/render...
content/renderer/render_widget.cc:1022: bool update_requested =
ime_requested_update_;
I don't think we should use a member variable to effectively pass an argument. 
If you want to clean up the majority of the callsites, I suggest doing the
following instead:

[private] void RenderWidget::SendTextInputState(ShowIme show_ime, bool
reply_to_request) {
  ...
}

void RenderWidget::UpdateTextInputState(ShowIme show_ime) {
  SendTextInputState(show_ime, false);
}

https://codereview.chromium.org/2596193002/diff/40001/content/renderer/render...
content/renderer/render_widget.cc:1064: #if defined(OS_ANDROID) ||
defined(USE_AURA)
Please remove "#if defined(OS_ANDROID) || defined(USE_AURA)" as it should be
no-op on other platforms anyway.

https://codereview.chromium.org/2596193002/diff/40001/content/renderer/render...
content/renderer/render_widget.cc:1065: params.update_requested =
update_requested;
I'd prefer name "params.reply_to_request"

https://codereview.chromium.org/2596193002/diff/40001/content/renderer/render...
content/renderer/render_widget.cc:1718: #if defined(OS_ANDROID) ||
defined(USE_AURA)
Can this #if be removed as well?

https://codereview.chromium.org/2596193002/diff/40001/content/renderer/render...
content/renderer/render_widget.cc:1876: #if defined(OS_ANDROID)
Maybe for another patch, but why is this #if OS(ANDROID)?  Seems weird.

[Changwan Ryu, 2017-01-04 06:40:24]

Description was changed from

==========
Clean up names and remove unnecessary parameter

is_non_ime_change and from_non_ime are difficult to understand - it's
negative and the meaning of non-ime change and from non-ime are unclear.

Replace these names by update_requested and ime_requested_update_.
Also, update_requested is currently set only in
RenderWidget::OnRequestTextInputStateUpdate(). We can remove the parameter
from all the other places by special-casing it and setting a member
variable instead.

Moreover, HIDE_IME does not *hide* IME, so replacing it by DO_NOT_SHOW
to make this point clear.

BUG=662279
==========

to

==========
Clean up names and remove unnecessary parameter

is_non_ime_change and from_non_ime are difficult to understand - it's
negative and the meaning of non-ime change and from non-ime are unclear.

Replace these names by update_requested and ime_requested_update_.
Also, update_requested is currently set only in
RenderWidget::OnRequestTextInputStateUpdate(). We can remove the parameter
from all the other places by special-casing it and setting a member
variable instead.

Moreover, HIDE_IME does not *hide* IME, so replacing it by DO_NOT_SHOW
to make this point clear.

BUG=662279
==========

[Changwan Ryu, 2017-01-04 06:42:42]

The CQ bit was checked by changwan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 06:42:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Changwan Ryu, 2017-01-04 06:43:46]

https://codereview.chromium.org/2596193002/diff/40001/content/renderer/render...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/2596193002/diff/40001/content/renderer/render...
content/renderer/render_widget.cc:1022: bool update_requested =
ime_requested_update_;
On 2017/01/04 00:59:51, aelias wrote:
> I don't think we should use a member variable to effectively pass an argument.

> If you want to clean up the majority of the callsites, I suggest doing the
> following instead:
> 
> [private] void RenderWidget::SendTextInputState(ShowIme show_ime, bool
> reply_to_request) {
>   ...
> }
> 
> void RenderWidget::UpdateTextInputState(ShowIme show_ime) {
>   SendTextInputState(show_ime, false);
> }

Sounds like a good idea. Changed it to UpdateTextInputStateInternal().

https://codereview.chromium.org/2596193002/diff/40001/content/renderer/render...
content/renderer/render_widget.cc:1064: #if defined(OS_ANDROID) ||
defined(USE_AURA)
On 2017/01/04 00:59:50, aelias wrote:
> Please remove "#if defined(OS_ANDROID) || defined(USE_AURA)" as it should be
> no-op on other platforms anyway.

Done.

https://codereview.chromium.org/2596193002/diff/40001/content/renderer/render...
content/renderer/render_widget.cc:1065: params.update_requested =
update_requested;
On 2017/01/04 00:59:50, aelias wrote:
> I'd prefer name "params.reply_to_request"

Changed.

https://codereview.chromium.org/2596193002/diff/40001/content/renderer/render...
content/renderer/render_widget.cc:1718: #if defined(OS_ANDROID) ||
defined(USE_AURA)
On 2017/01/04 00:59:51, aelias wrote:
> Can this #if be removed as well?

Done. MacOSX does not seem to use it.

https://codereview.chromium.org/2596193002/diff/40001/content/renderer/render...
content/renderer/render_widget.cc:1876: #if defined(OS_ANDROID)
On 2017/01/04 00:59:50, aelias wrote:
> Maybe for another patch, but why is this #if OS(ANDROID)?  Seems weird.

Filed crbug.com/678163 .

[commit-bot: I haz the power, 2017-01-04 07:31:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 07:31:41]

Dry run: This issue passed the CQ dry run.

[aelias_OOO_until_Jul13, 2017-01-04 20:11:01]

lgtm modulo further naming change:

https://codereview.chromium.org/2596193002/diff/60001/content/common/view_mes...
File content/common/view_messages.h (right):

https://codereview.chromium.org/2596193002/diff/60001/content/common/view_mes...
content/common/view_messages.h:288: IPC_STRUCT_TRAITS_MEMBER(show_ime_if_needed)
Please rename to "show_virtual_keyboard" (and everywhere similar name appears).

https://codereview.chromium.org/2596193002/diff/60001/content/renderer/input/...
File content/renderer/input/render_widget_input_handler_delegate.h (right):

https://codereview.chromium.org/2596193002/diff/60001/content/renderer/input/...
content/renderer/input/render_widget_input_handler_delegate.h:27: enum class
ShowIme { IF_NEEDED, DO_NOT_SHOW };
I think I'd prefer the following naming:

enum class ShowVirtualKeyboard { SHOW, DO_NOT_CHANGE };

Reasoning:
- "Virtual Keyboard" is more specific than "IME".
- "SHOW" makes it clear that this always results in the keyboard getting shown. 
It goes without saying that this is no-op if already shown.
- "DO_NOT_CHANGE" makes it clear that keyboard remains in current state (I think
"DO_NOT_SHOW" is still ambiguous on this).

[Changwan Ryu, 2017-01-05 08:47:03]

https://codereview.chromium.org/2596193002/diff/60001/content/renderer/input/...
File content/renderer/input/render_widget_input_handler_delegate.h (right):

https://codereview.chromium.org/2596193002/diff/60001/content/renderer/input/...
content/renderer/input/render_widget_input_handler_delegate.h:27: enum class
ShowIme { IF_NEEDED, DO_NOT_SHOW };
On 2017/01/04 20:11:01, aelias wrote:
> I think I'd prefer the following naming:
> 
> enum class ShowVirtualKeyboard { SHOW, DO_NOT_CHANGE };
> 
> Reasoning:
> - "Virtual Keyboard" is more specific than "IME".
> - "SHOW" makes it clear that this always results in the keyboard getting
shown. 
> It goes without saying that this is no-op if already shown.
> - "DO_NOT_CHANGE" makes it clear that keyboard remains in current state (I
think
> "DO_NOT_SHOW" is still ambiguous on this).

I agree that virtual keyboard is much clearer than IME. ShowIme is only used for
Android and Chrome OS, and Android has recently started using 'virtual keyboard'
in the settings.

But one of the cons here is the lengthiness.
ShowVirtualKeyboard show_virtual_keyboard as a parameter is probably too long.

How about adding a separate virtual function ShowVirtualKeyboard() such that in
normal cases UpdateTextInputState() does not require a parameter?

[aelias_OOO_until_Jul13, 2017-01-05 23:20:55]

On 2017/01/05 at 08:47:03, changwan wrote:
> How about adding a separate virtual function ShowVirtualKeyboard() such that
in normal cases UpdateTextInputState() does not require a parameter?

Sounds good to me.

[Changwan Ryu, 2017-01-10 01:39:14]

The CQ bit was checked by changwan@chromium.org to run a CQ dry run

[Changwan Ryu, 2017-01-10 01:40:11]

Description was changed from

==========
Clean up names and remove unnecessary parameter

is_non_ime_change and from_non_ime are difficult to understand - it's
negative and the meaning of non-ime change and from non-ime are unclear.

Replace these names by update_requested and ime_requested_update_.
Also, update_requested is currently set only in
RenderWidget::OnRequestTextInputStateUpdate(). We can remove the parameter
from all the other places by special-casing it and setting a member
variable instead.

Moreover, HIDE_IME does not *hide* IME, so replacing it by DO_NOT_SHOW
to make this point clear.

BUG=662279
==========

to

==========
Clean up names and remove unnecessary parameter

is_non_ime_change and from_non_ime are difficult to understand - it's
negative and the meaning of non-ime change and from non-ime are unclear.
Also, !is_non_ime_change is a double negative and can be very confusing.

Replace these names by reply_to_request.
Also, reply_to_request is currently set only in
RenderWidget::OnRequestTextInputStateUpdate(). By having it call an internal
function, we can remove the parameter from all the other call sites.

Moreover, HIDE_IME is incorrectly named - it does not hide virtual keyboard.

And SHOW_IME and showImeIfNeeded() are mildly confusing - it may sound as
if it affected hardware keyboard but it is actually only concerned with
virtual keyboard. "IfNeeded" was added to stress the point that it only
affects virtual keyboard case. ImeOnFocusTest.cpp is easier to read after
this change.

By adding another function ShowVirtualKeyboard(), the call sites no longer
need to pass a parameter.

Note that showImeIfNeeded() and show_ime_if_needed in the message and
browser process have not changed yet. There are up to 100 files that
are affected, so I will separate them out as a single-themed change.

BUG=662279
==========

[Changwan Ryu, 2017-01-10 01:40:34]

Could you take another look? Thanks.

[commit-bot: I haz the power, 2017-01-10 01:40:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-01-10 01:49:55]

lgtm modulo comment

https://codereview.chromium.org/2596193002/diff/80001/content/renderer/render...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/2596193002/diff/80001/content/renderer/render...
content/renderer/render_widget.cc:1025: void RenderWidget::ShowVirtualKeyboard()
{
Could you avoid introducing the capitalized one and just use
showVirtualKeyboard?  I think additional calls to FocusChangeComplete() should
be harmless.

[commit-bot: I haz the power, 2017-01-10 03:43:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:43:37]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Changwan Ryu, 2017-01-12 04:53:10]

https://codereview.chromium.org/2596193002/diff/80001/content/renderer/render...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/2596193002/diff/80001/content/renderer/render...
content/renderer/render_widget.cc:1025: void RenderWidget::ShowVirtualKeyboard()
{
On 2017/01/10 01:49:55, aelias wrote:
> Could you avoid introducing the capitalized one and just use
> showVirtualKeyboard?  I think additional calls to FocusChangeComplete() should
> be harmless.

As we talked offline,
RenderWidget::ShowVirtualKeyboard() implements
RenderWidgetInputHandlerDelegate::ShowVirtualKeyboard() while
RenderWidget::showVirtualKeyboard() implements
WebWidgetClient::showVirtualKeyboard(), so I cannot unify them.

[Changwan Ryu, 2017-01-12 05:00:54]

changwan@chromium.org changed reviewers:
+ boliu@chromium.org, dcheng@chromium.org, nasko@chromium.org

[Changwan Ryu, 2017-01-12 05:00:54]

Adding owners.


boliu@chromium.org: Please review changes in 
content_view_core_impl.*


dcheng@chromium.org: Please review changes in 
content/common/view_messages.h
third_party/WebKit/Source/core/dom/Element.cpp
third_party/WebKit/Source/core/page/ChromeClient.h


nasko@chromium.org: Please review changes in 
content/common/text_input_state.*
content/public/test/text_input_test_utils.*
content/test/layouttest_support.cc

[boliu, 2017-01-12 05:05:59]

On 2017/01/12 05:00:54, Changwan Ryu wrote:
> Adding owners.
> 
> 
> mailto:boliu@chromium.org: Please review changes in 
> content_view_core_impl.*

rs lgtm

> 
> 
> mailto:dcheng@chromium.org: Please review changes in 
> content/common/view_messages.h
> third_party/WebKit/Source/core/dom/Element.cpp
> third_party/WebKit/Source/core/page/ChromeClient.h
> 
> 
> mailto:nasko@chromium.org: Please review changes in 
> content/common/text_input_state.*
> content/public/test/text_input_test_utils.*
> content/test/layouttest_support.cc

[nasko, 2017-01-12 19:18:30]

Rubberstamp LGTM on:

content/common/text_input_state.*
content/public/test/text_input_test_utils.*
content/test/layouttest_support.cc
content/common/view_messages.h

[dcheng, 2017-01-12 23:18:01]

blink lgtm

[Changwan Ryu, 2017-01-13 01:24:21]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2017-01-13 01:25:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 01:29:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 01:29:11]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Changwan Ryu, 2017-01-13 01:33:44]

The CQ bit was checked by changwan@chromium.org

[Changwan Ryu, 2017-01-13 01:33:45]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
boliu@chromium.org, dcheng@chromium.org, nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2596193002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-13 01:34:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 01:38:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 01:38:36]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Changwan Ryu, 2017-01-13 07:24:31]

The CQ bit was checked by changwan@chromium.org

[Changwan Ryu, 2017-01-13 07:24:31]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
boliu@chromium.org, dcheng@chromium.org, nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2596193002/#ps120001
(title: "rebased")

[commit-bot: I haz the power, 2017-01-13 07:24:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 08:17:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 08:17:49]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Changwan Ryu, 2017-01-15 23:34:29]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2017-01-15 23:34:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 01:06:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 01:06:48]

Failed to apply patch for
content/browser/renderer_host/render_widget_host_view_android.cc:
While running git apply --index -p1;
  error: patch failed:
content/browser/renderer_host/render_widget_host_view_android.cc:783
  error: content/browser/renderer_host/render_widget_host_view_android.cc: patch
does not apply

Patch:       content/browser/renderer_host/render_widget_host_view_android.cc
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc
b/content/browser/renderer_host/render_widget_host_view_android.cc
index
0fc0b32cdbd031bee516273c67b00ab7692f6d11..990d141ecc6910315c3521df8fa6109e36a7e0ab
100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -783,7 +783,7 @@ void
RenderWidgetHostViewAndroid::OnUpdateTextInputStateCalled(
       GetNativeImeAdapter(), static_cast<int>(state.type), state.flags,
       state.mode, state.value, state.selection_start, state.selection_end,
       state.composition_start, state.composition_end, state.show_ime_if_needed,
-      state.is_non_ime_change);
+      state.reply_to_request);
 }
 
 void RenderWidgetHostViewAndroid::UpdateBackgroundColor(SkColor color) {

[Changwan Ryu, 2017-01-16 01:27:56]

The CQ bit was checked by changwan@chromium.org

[Changwan Ryu, 2017-01-16 01:27:57]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
boliu@chromium.org, dcheng@chromium.org, nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2596193002/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-16 01:28:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 02:55:05]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1484530076595910,
"parent_rev": "dbfd395c0b0c309c6c8865a372f0bc16ddfe9bbc", "commit_rev":
"75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae"}

[commit-bot: I haz the power, 2017-01-16 02:55:37]

Description was changed from

==========
Clean up names and remove unnecessary parameter

is_non_ime_change and from_non_ime are difficult to understand - it's
negative and the meaning of non-ime change and from non-ime are unclear.
Also, !is_non_ime_change is a double negative and can be very confusing.

Replace these names by reply_to_request.
Also, reply_to_request is currently set only in
RenderWidget::OnRequestTextInputStateUpdate(). By having it call an internal
function, we can remove the parameter from all the other call sites.

Moreover, HIDE_IME is incorrectly named - it does not hide virtual keyboard.

And SHOW_IME and showImeIfNeeded() are mildly confusing - it may sound as
if it affected hardware keyboard but it is actually only concerned with
virtual keyboard. "IfNeeded" was added to stress the point that it only
affects virtual keyboard case. ImeOnFocusTest.cpp is easier to read after
this change.

By adding another function ShowVirtualKeyboard(), the call sites no longer
need to pass a parameter.

Note that showImeIfNeeded() and show_ime_if_needed in the message and
browser process have not changed yet. There are up to 100 files that
are affected, so I will separate them out as a single-themed change.

BUG=662279
==========

to

==========
Clean up names and remove unnecessary parameter

is_non_ime_change and from_non_ime are difficult to understand - it's
negative and the meaning of non-ime change and from non-ime are unclear.
Also, !is_non_ime_change is a double negative and can be very confusing.

Replace these names by reply_to_request.
Also, reply_to_request is currently set only in
RenderWidget::OnRequestTextInputStateUpdate(). By having it call an internal
function, we can remove the parameter from all the other call sites.

Moreover, HIDE_IME is incorrectly named - it does not hide virtual keyboard.

And SHOW_IME and showImeIfNeeded() are mildly confusing - it may sound as
if it affected hardware keyboard but it is actually only concerned with
virtual keyboard. "IfNeeded" was added to stress the point that it only
affects virtual keyboard case. ImeOnFocusTest.cpp is easier to read after
this change.

By adding another function ShowVirtualKeyboard(), the call sites no longer
need to pass a parameter.

Note that showImeIfNeeded() and show_ime_if_needed in the message and
browser process have not changed yet. There are up to 100 files that
are affected, so I will separate them out as a single-themed change.

BUG=662279

Review-Url: https://codereview.chromium.org/2596193002
Cr-Commit-Position: refs/heads/master@{#443836}
Committed:
https://chromium.googlesource.com/chromium/src/+/75e3b207a503c0ad4ad141ca78b7...
==========

[commit-bot: I haz the power, 2017-01-16 02:55:38]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/75e3b207a503c0ad4ad141ca78b7...