Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Unified Diff: content/renderer/render_widget.h

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.h
diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h
index 7c71a0eeca37a25d80b4d05783eea310cee716db..c446998493b5356cbc81c1b77692d27cc02a605a 100644
--- a/content/renderer/render_widget.h
+++ b/content/renderer/render_widget.h
@@ -264,8 +264,8 @@ class CONTENT_EXPORT RenderWidget
void NotifyInputEventHandled(blink::WebInputEvent::Type handled_type,
InputEventAckState ack_result) override;
void SetInputHandler(RenderWidgetInputHandler* input_handler) override;
- void UpdateTextInputState(ShowIme show_ime,
- ChangeSource change_source) override;
+ void ShowVirtualKeyboard() override;
+ void UpdateTextInputState() override;
bool WillHandleGestureEvent(const blink::WebGestureEvent& event) override;
bool WillHandleMouseEvent(const blink::WebMouseEvent& event) override;
@@ -297,7 +297,7 @@ class CONTENT_EXPORT RenderWidget
const blink::WebFloatSize& accumulatedOverscroll,
const blink::WebFloatPoint& position,
const blink::WebFloatSize& velocity) override;
- void showImeIfNeeded() override;
+ void showVirtualKeyboard() override;
void convertViewportToWindow(blink::WebRect* rect) override;
void convertWindowToViewport(blink::WebFloatRect* rect) override;
bool requestPointerLock() override;
@@ -809,6 +809,9 @@ class CONTENT_EXPORT RenderWidget
// handle the event, or there is no page focus.
bool ShouldHandleImeEvents() const;
+ void UpdateTextInputStateInternal(bool show_virtual_keyboard,
+ bool reply_to_request);
+
// Indicates whether this widget has focus.
bool has_focus_;
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698