Clean up names and remove unnecessary parameter

content/renderer/input/render_widget_input_handler_delegate.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_
 #define CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_
 
 #include <memory>
 
 #include "content/common/content_export.h"
 #include "content/common/input/input_event_ack.h"
 
 namespace blink {
 class WebGestureEvent;
 class WebMouseEvent;
 }
 
 namespace gfx {
 class Point;
 class Vector2dF;
 }
 
 namespace content {
 
 class RenderWidgetInputHandler;
 
-enum class ShowIme { IF_NEEDED, HIDE_IME };
-
-enum class ChangeSource {
-  FROM_NON_IME,
-  FROM_IME,
-};
+enum class ShowIme { IF_NEEDED, DO_NOT_SHOW };

[aelias_OOO_until_Jul13, 2017/01/04 20:11:01]

I think I'd prefer the following naming:

enum class ShowVirtualKeyboard { SHOW, DO_NOT_CHANGE };

Reasoning:
- "Virtual Keyboard" is more specific than "IME".
- "SHOW" makes it clear that this always results in the keyboard getting shown. 
It goes without saying that this is no-op if already shown.
- "DO_NOT_CHANGE" makes it clear that keyboard remains in current state (I think
"DO_NOT_SHOW" is still ambiguous on this).

[Changwan Ryu, 2017/01/05 08:47:03]

I agree that virtual keyboard is much clearer than IME. ShowIme is only used for
Android and Chrome OS, and Android has recently started using 'virtual keyboard'
in the settings.

But one of the cons here is the lengthiness.
ShowVirtualKeyboard show_virtual_keyboard as a parameter is probably too long.

How about adding a separate virtual function ShowVirtualKeyboard() such that in
normal cases UpdateTextInputState() does not require a parameter?

 
 // Consumers of RenderWidgetInputHandler implement this delegate in order to
 // transport input handling information across processes.
 class CONTENT_EXPORT RenderWidgetInputHandlerDelegate {
  public:
   // Called when animations due to focus change have completed (if any).
   virtual void FocusChangeComplete() = 0;
 
   // Check whether the WebWidget has any touch event handlers registered
   // at the given point.
@@ skipping 20 matching lines @@
   // (DISPATCH_TYPE_*_NOTIFY_MAIN) of |handled_type| has been processed
   // by the main thread.
   virtual void NotifyInputEventHandled(blink::WebInputEvent::Type handled_type,
                                        InputEventAckState ack_result) = 0;
 
   // Notifies the delegate of the |input_handler| managing it.
   virtual void SetInputHandler(RenderWidgetInputHandler* input_handler) = 0;
 
   // |show_ime| should be ShowIme::IF_NEEDED iff the update may cause the ime to
   // be displayed, e.g. after a tap on an input field on mobile.
-  // |change_source| should be ChangeSource::FROM_NON_IME when the renderer has
-  // to wait for the browser to acknowledge the change before the renderer
-  // handles any more IME events. This is when the text change did not originate
-  // from the IME in the browser side, such as changes by JavaScript or
-  // autofill.
-  virtual void UpdateTextInputState(ShowIme show_ime,
-                                    ChangeSource change_source) = 0;
+  virtual void UpdateTextInputState(ShowIme show_ime) = 0;
 
   // Notifies that a gesture event is about to be handled.
   // Returns true if no further handling is needed. In that case, the event
   // won't be sent to WebKit.
   virtual bool WillHandleGestureEvent(const blink::WebGestureEvent& event) = 0;
 
   // Notifies that a mouse event is about to be handled.
   // Returns true if no further handling is needed. In that case, the event
   // won't be sent to WebKit or trigger DidHandleMouseEvent().
   virtual bool WillHandleMouseEvent(const blink::WebMouseEvent& event) = 0;
 
  protected:
   virtual ~RenderWidgetInputHandlerDelegate() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_INPUT_RENDER_WIDGET_INPUT_HANDLER_DELEGATE_H_