Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
index fd5833f51d75472e3b1ac15d1520e84e32790c69..df58b85a1caa6589cebf562a34cb16f6ee454732 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
@@ -304,10 +304,10 @@ public class ImeAdapter {
* composition.
* @param compositionEnd The character offset of the composition end, or -1 if there is no
* selection.
- * @param isNonImeChange True when the update was caused by non-IME (e.g. Javascript).
+ * @param replyToRequest True when the update was requested by IME.
*/
public void updateState(String text, int selectionStart, int selectionEnd, int compositionStart,
- int compositionEnd, boolean isNonImeChange) {
+ int compositionEnd, boolean replyToRequest) {
if (mCursorAnchorInfoController != null && (!TextUtils.equals(mLastText, text)
|| mLastSelectionStart != selectionStart || mLastSelectionEnd != selectionEnd
|| mLastCompositionStart != compositionStart
@@ -324,7 +324,7 @@ public class ImeAdapter {
boolean singleLine = mTextInputType != TextInputType.TEXT_AREA
&& mTextInputType != TextInputType.CONTENT_EDITABLE;
mInputConnection.updateStateOnUiThread(text, selectionStart, selectionEnd, compositionStart,
- compositionEnd, singleLine, isNonImeChange);
+ compositionEnd, singleLine, replyToRequest);
}
/**

Powered by Google App Engine
This is Rietveld 408576698