Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1466)

Unified Diff: content/renderer/input/render_widget_input_handler.cc

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/ime_event_guard.cc ('k') | content/renderer/input/render_widget_input_handler_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/input/render_widget_input_handler.cc
diff --git a/content/renderer/input/render_widget_input_handler.cc b/content/renderer/input/render_widget_input_handler.cc
index 6e1ad1e086b5544e2860946f1b6250cd54668d13..63e11df6e3db80c527866aa9fe50593dbeaa58f0 100644
--- a/content/renderer/input/render_widget_input_handler.cc
+++ b/content/renderer/input/render_widget_input_handler.cc
@@ -279,7 +279,7 @@ void RenderWidgetInputHandler::HandleInputEvent(
static_cast<const WebKeyboardEvent&>(input_event);
if (key_event.nativeKeyCode == AKEYCODE_DPAD_CENTER &&
widget_->GetTextInputType() != ui::TEXT_INPUT_TYPE_NONE) {
- widget_->showImeIfNeeded();
+ widget_->showVirtualKeyboard();
prevent_default = true;
}
#endif
@@ -415,8 +415,7 @@ void RenderWidgetInputHandler::HandleInputEvent(
// of a processed touch end event.
if (input_event.type() == WebInputEvent::TouchEnd &&
processed != WebInputEventResult::NotHandled) {
- delegate_->UpdateTextInputState(ShowIme::IF_NEEDED,
- ChangeSource::FROM_NON_IME);
+ delegate_->ShowVirtualKeyboard();
}
#elif defined(USE_AURA)
// Show the virtual keyboard if enabled and a user gesture triggers a focus
@@ -424,7 +423,7 @@ void RenderWidgetInputHandler::HandleInputEvent(
if (processed != WebInputEventResult::NotHandled &&
(input_event.type() == WebInputEvent::TouchEnd ||
input_event.type() == WebInputEvent::MouseUp)) {
- delegate_->UpdateTextInputState(ShowIme::IF_NEEDED, ChangeSource::FROM_IME);
+ delegate_->ShowVirtualKeyboard();
}
#endif
« no previous file with comments | « content/renderer/ime_event_guard.cc ('k') | content/renderer/input/render_widget_input_handler_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698