Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2803)

Unified Diff: content/renderer/input/render_widget_input_handler_delegate.h

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/input/render_widget_input_handler_delegate.h
diff --git a/content/renderer/input/render_widget_input_handler_delegate.h b/content/renderer/input/render_widget_input_handler_delegate.h
index 4c245f2eb0060b8d292b1e4c7ff34578dae364b0..d1fd030b3789ed8ccdf52b1cbfe7fe283929077d 100644
--- a/content/renderer/input/render_widget_input_handler_delegate.h
+++ b/content/renderer/input/render_widget_input_handler_delegate.h
@@ -24,13 +24,6 @@ namespace content {
class RenderWidgetInputHandler;
-enum class ShowIme { IF_NEEDED, HIDE_IME };
-
-enum class ChangeSource {
- FROM_NON_IME,
- FROM_IME,
-};
-
// Consumers of RenderWidgetInputHandler implement this delegate in order to
// transport input handling information across processes.
class CONTENT_EXPORT RenderWidgetInputHandlerDelegate {
@@ -68,15 +61,14 @@ class CONTENT_EXPORT RenderWidgetInputHandlerDelegate {
// Notifies the delegate of the |input_handler| managing it.
virtual void SetInputHandler(RenderWidgetInputHandler* input_handler) = 0;
- // |show_ime| should be ShowIme::IF_NEEDED iff the update may cause the ime to
- // be displayed, e.g. after a tap on an input field on mobile.
- // |change_source| should be ChangeSource::FROM_NON_IME when the renderer has
- // to wait for the browser to acknowledge the change before the renderer
- // handles any more IME events. This is when the text change did not originate
- // from the IME in the browser side, such as changes by JavaScript or
- // autofill.
- virtual void UpdateTextInputState(ShowIme show_ime,
- ChangeSource change_source) = 0;
+ // Call this if virtual keyboard should be displayed, e.g. after a tap on an
+ // input field on mobile. Note that we do this just by setting a bit in
+ // text input state and update it to the browser such that browser process can
+ // be up to date when showing virtual keyboard.
+ virtual void ShowVirtualKeyboard() = 0;
+
+ // Send an update of text input state to the browser process.
+ virtual void UpdateTextInputState() = 0;
// Notifies that a gesture event is about to be handled.
// Returns true if no further handling is needed. In that case, the event
« no previous file with comments | « content/renderer/input/render_widget_input_handler.cc ('k') | content/renderer/mus/render_widget_mus_connection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698