Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/test/layouttest_support.cc ('k') | third_party/WebKit/Source/core/page/ChromeClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * (C) 2007 Eric Seidel (eric@webkit.org) 9 * (C) 2007 Eric Seidel (eric@webkit.org)
10 * 10 *
(...skipping 2648 matching lines...) Expand 10 before | Expand all | Expand 10 after
2659 if (!document().page()->focusController().setFocusedElement( 2659 if (!document().page()->focusController().setFocusedElement(
2660 this, document().frame(), params)) 2660 this, document().frame(), params))
2661 return; 2661 return;
2662 2662
2663 if (document().focusedElement() == this && 2663 if (document().focusedElement() == this &&
2664 document().hasReceivedUserGesture()) { 2664 document().hasReceivedUserGesture()) {
2665 // Bring up the keyboard in the context of anything triggered by a user 2665 // Bring up the keyboard in the context of anything triggered by a user
2666 // gesture. Since tracking that across arbitrary boundaries (eg. 2666 // gesture. Since tracking that across arbitrary boundaries (eg.
2667 // animations) is difficult, for now we match IE's heuristic and bring 2667 // animations) is difficult, for now we match IE's heuristic and bring
2668 // up the keyboard if there's been any gesture since load. 2668 // up the keyboard if there's been any gesture since load.
2669 document().page()->chromeClient().showImeIfNeeded(); 2669 document().page()->chromeClient().showVirtualKeyboard();
2670 } 2670 }
2671 } 2671 }
2672 2672
2673 void Element::updateFocusAppearance( 2673 void Element::updateFocusAppearance(
2674 SelectionBehaviorOnFocus selectionBehavior) { 2674 SelectionBehaviorOnFocus selectionBehavior) {
2675 if (selectionBehavior == SelectionBehaviorOnFocus::None) 2675 if (selectionBehavior == SelectionBehaviorOnFocus::None)
2676 return; 2676 return;
2677 if (isRootEditableElement(*this)) { 2677 if (isRootEditableElement(*this)) {
2678 LocalFrame* frame = document().frame(); 2678 LocalFrame* frame = document().frame();
2679 if (!frame) 2679 if (!frame)
(...skipping 1450 matching lines...) Expand 10 before | Expand all | Expand 10 after
4130 } 4130 }
4131 4131
4132 DEFINE_TRACE_WRAPPERS(Element) { 4132 DEFINE_TRACE_WRAPPERS(Element) {
4133 if (hasRareData()) { 4133 if (hasRareData()) {
4134 visitor->traceWrappers(elementRareData()); 4134 visitor->traceWrappers(elementRareData());
4135 } 4135 }
4136 ContainerNode::traceWrappers(visitor); 4136 ContainerNode::traceWrappers(visitor);
4137 } 4137 }
4138 4138
4139 } // namespace blink 4139 } // namespace blink
OLDNEW
« no previous file with comments | « content/test/layouttest_support.cc ('k') | third_party/WebKit/Source/core/page/ChromeClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698