third_party/WebKit/Source/web/ChromeClientImpl.cpp - Issue 2596193002: Clean up names and remove unnecessary parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

index 3fa95b1acba63daf17ed614e1a0d8f96c0bfaa36..11d980e89a6250fd8cc4a10933d6ccef31805e9e 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

@@ -1023,9 +1023,9 @@ void ChromeClientImpl::resetInputMethod() {

m_webView->client()->resetInputMethod();

}

-void ChromeClientImpl::showImeIfNeeded() {

+void ChromeClientImpl::showVirtualKeyboard() {

if (m_webView->client())

- m_webView->client()->showImeIfNeeded();

+ m_webView->client()->showVirtualKeyboard();

}

void ChromeClientImpl::showUnhandledTapUIIfNeeded(