Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java
index 92c24c983c1916478a95ecf393038a6603a89329..330863f770afba4ebd4f622cea8c596ed73abd87 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java
@@ -114,22 +114,21 @@ class ThreadedInputConnection extends BaseInputConnection implements ChromiumBas
}
@Override
- public void updateStateOnUiThread(String text, final int selectionStart,
- final int selectionEnd, final int compositionStart, final int compositionEnd,
- boolean singleLine, final boolean isNonImeChange) {
+ public void updateStateOnUiThread(String text, final int selectionStart, final int selectionEnd,
+ final int compositionStart, final int compositionEnd, boolean singleLine,
+ final boolean replyToRequest) {
ImeUtils.checkOnUiThread();
// crbug.com/663880: Non-breaking spaces can cause the IME to get confused. Replace with
// normal spaces.
text = text.replace('\u00A0', ' ');
- mCachedTextInputState =
- new TextInputState(text, new Range(selectionStart, selectionEnd),
- new Range(compositionStart, compositionEnd), singleLine, !isNonImeChange);
+ mCachedTextInputState = new TextInputState(text, new Range(selectionStart, selectionEnd),
+ new Range(compositionStart, compositionEnd), singleLine, replyToRequest);
if (DEBUG_LOGS) Log.w(TAG, "updateState: %s", mCachedTextInputState);
addToQueueOnUiThread(mCachedTextInputState);
- if (isNonImeChange) {
+ if (!replyToRequest) {
mHandler.post(mProcessPendingInputStatesRunnable);
}
}
@@ -270,7 +269,7 @@ class ThreadedInputConnection extends BaseInputConnection implements ChromiumBas
if (state.shouldUnblock()) {
if (DEBUG_LOGS) Log.w(TAG, "blockAndGetStateUpdate: unblocked");
return null;
- } else if (state.fromIme()) {
+ } else if (state.replyToRequest()) {
if (shouldUpdateSelection) updateSelection(state);
if (DEBUG_LOGS) Log.w(TAG, "blockAndGetStateUpdate done: %d", mQueue.size());
return state;

Powered by Google App Engine
This is Rietveld 408576698