Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2588043002: Pass value and use std::move instead of const reference for ack listeners. (Closed)

Created:
4 years ago by Fan Yang
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass value and use std::move instead of const reference for ack listeners. Merge internal change 142446499. BUG= Committed: https://crrev.com/2969c3272aecd7f24e7669434ca6687ab5509270 Cr-Commit-Position: refs/heads/master@{#439548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -154 lines) Patch
M net/quic/chromium/quic_chromium_client_stream.h View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream_test.cc View 2 chunks +15 lines, -15 lines 0 comments Download
M net/quic/core/quic_ack_listener_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_ack_listener_interface.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/quic/core/quic_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_connection.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/core/quic_headers_stream.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_headers_stream.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M net/quic/core/quic_packet_creator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_packet_creator.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/core/quic_packet_generator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_packet_generator.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/core/quic_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_session.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_session_test.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M net/quic/core/quic_spdy_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_spdy_session.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_spdy_stream.h View 2 chunks +4 lines, -5 lines 0 comments Download
M net/quic/core/quic_spdy_stream.cc View 4 chunks +14 lines, -11 lines 0 comments Download
M net/quic/core/quic_stream.h View 3 chunks +5 lines, -6 lines 0 comments Download
M net/quic/core/quic_stream.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quartc/quartc_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_peer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_peer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 3 chunks +21 lines, -22 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 2 chunks +13 lines, -14 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 3 chunks +7 lines, -8 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 4 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
Fan Yang
4 years ago (2016-12-19 19:28:55 UTC) #5
Ryan Hamilton
lgtm
4 years ago (2016-12-19 19:31:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2588043002/1
4 years ago (2016-12-19 20:43:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 20:51:16 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-19 20:55:35 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2969c3272aecd7f24e7669434ca6687ab5509270
Cr-Commit-Position: refs/heads/master@{#439548}

Powered by Google App Engine
This is Rietveld 408576698