Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: net/quic/core/quic_packet_creator.cc

Issue 2588043002: Pass value and use std::move instead of const reference for ack listeners. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_packet_creator.h ('k') | net/quic/core/quic_packet_generator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_packet_creator.cc
diff --git a/net/quic/core/quic_packet_creator.cc b/net/quic/core/quic_packet_creator.cc
index d4bf8ece7256fbd8475128d6251e9690d014b77e..b5a708ac3baf3e05fa8bd5b556369e7fb6c77277 100644
--- a/net/quic/core/quic_packet_creator.cc
+++ b/net/quic/core/quic_packet_creator.cc
@@ -353,7 +353,7 @@ void QuicPacketCreator::CreateAndSerializeStreamFrame(
QuicStreamOffset iov_offset,
QuicStreamOffset stream_offset,
bool fin,
- const scoped_refptr<QuicAckListenerInterface>& listener,
+ scoped_refptr<QuicAckListenerInterface> listener,
size_t* num_bytes_consumed) {
DCHECK(queued_frames_.empty());
// Write out the packet header
@@ -413,7 +413,7 @@ void QuicPacketCreator::CreateAndSerializeStreamFrame(
packet_.encrypted_buffer = encrypted_buffer;
packet_.encrypted_length = encrypted_length;
if (listener != nullptr) {
- packet_.listeners.emplace_back(listener, bytes_consumed);
+ packet_.listeners.emplace_back(std::move(listener), bytes_consumed);
}
packet_.retransmittable_frames.push_back(QuicFrame(frame.release()));
OnSerializedPacket();
@@ -465,10 +465,10 @@ bool QuicPacketCreator::AddPaddedSavedFrame(const QuicFrame& frame) {
}
void QuicPacketCreator::AddAckListener(
- const scoped_refptr<QuicAckListenerInterface>& listener,
+ scoped_refptr<QuicAckListenerInterface> listener,
QuicPacketLength length) {
DCHECK(!queued_frames_.empty());
- packet_.listeners.emplace_back(listener, length);
+ packet_.listeners.emplace_back(std::move(listener), length);
}
void QuicPacketCreator::SerializePacket(char* encrypted_buffer,
« no previous file with comments | « net/quic/core/quic_packet_creator.h ('k') | net/quic/core/quic_packet_generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698