Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: net/quic/test_tools/quic_test_utils.h

Issue 2588043002: Pass value and use std::move instead of const reference for ack listeners. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_stream_peer.cc ('k') | net/tools/quic/quic_simple_server_session_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/quic_test_utils.h
diff --git a/net/quic/test_tools/quic_test_utils.h b/net/quic/test_tools/quic_test_utils.h
index fa773b723f9ca2cb68d61027c84d45d57c6f2c48..0d1c90ace4260f0d897e39efbed612ca51160767 100644
--- a/net/quic/test_tools/quic_test_utils.h
+++ b/net/quic/test_tools/quic_test_utils.h
@@ -512,14 +512,13 @@ class MockQuicSession : public QuicSession {
MOCK_METHOD1(CreateOutgoingDynamicStream, QuicStream*(SpdyPriority priority));
MOCK_METHOD1(ShouldCreateIncomingDynamicStream, bool(QuicStreamId id));
MOCK_METHOD0(ShouldCreateOutgoingDynamicStream, bool());
- MOCK_METHOD6(
- WritevData,
- QuicConsumedData(QuicStream* stream,
- QuicStreamId id,
- QuicIOVector data,
- QuicStreamOffset offset,
- bool fin,
- const scoped_refptr<QuicAckListenerInterface>&));
+ MOCK_METHOD6(WritevData,
+ QuicConsumedData(QuicStream* stream,
+ QuicStreamId id,
+ QuicIOVector data,
+ QuicStreamOffset offset,
+ bool fin,
+ scoped_refptr<QuicAckListenerInterface>));
MOCK_METHOD3(SendRstStream,
void(QuicStreamId stream_id,
@@ -571,14 +570,14 @@ class MockQuicSpdySession : public QuicSpdySession {
QuicSpdyStream*(SpdyPriority priority));
MOCK_METHOD1(ShouldCreateIncomingDynamicStream, bool(QuicStreamId id));
MOCK_METHOD0(ShouldCreateOutgoingDynamicStream, bool());
- MOCK_METHOD6(WritevData,
- QuicConsumedData(QuicStream* stream,
- QuicStreamId id,
- QuicIOVector data,
- QuicStreamOffset offset,
- bool fin,
- const scoped_refptr<QuicAckListenerInterface>&
- ack_listener));
+ MOCK_METHOD6(
+ WritevData,
+ QuicConsumedData(QuicStream* stream,
+ QuicStreamId id,
+ QuicIOVector data,
+ QuicStreamOffset offset,
+ bool fin,
+ scoped_refptr<QuicAckListenerInterface> ack_listener));
MOCK_METHOD3(SendRstStream,
void(QuicStreamId stream_id,
@@ -610,12 +609,12 @@ class MockQuicSpdySession : public QuicSpdySession {
const QuicHeaderList& header_list));
// Methods taking non-copyable types like SpdyHeaderBlock by value cannot be
// mocked directly.
- size_t WriteHeaders(QuicStreamId id,
- SpdyHeaderBlock headers,
- bool fin,
- SpdyPriority priority,
- const scoped_refptr<QuicAckListenerInterface>&
- ack_notifier_delegate) override {
+ size_t WriteHeaders(
+ QuicStreamId id,
+ SpdyHeaderBlock headers,
+ bool fin,
+ SpdyPriority priority,
+ scoped_refptr<QuicAckListenerInterface> ack_notifier_delegate) override {
write_headers_ = std::move(headers);
return WriteHeadersMock(id, write_headers_, fin, priority,
ack_notifier_delegate);
« no previous file with comments | « net/quic/test_tools/quic_stream_peer.cc ('k') | net/tools/quic/quic_simple_server_session_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698