Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2580393003: Replace QuicAckListenerInterface* with scoped_refptr<QuicAckListenerInterface>. (Closed)

Created:
4 years ago by Fan Yang
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace QuicAckListenerInterface* with scoped_refptr<QuicAckListenerInterface>. Merge internal change 142151597 BUG= Committed: https://crrev.com/8bc4ec0dac01c4b68221ea3a29db4cd47abac170 Cr-Commit-Position: refs/heads/master@{#439524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -238 lines) Patch
M net/quic/chromium/quic_chromium_client_stream.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_client_stream_test.cc View 3 chunks +16 lines, -14 lines 0 comments Download
M net/quic/core/quic_ack_listener_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_ack_listener_interface.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/core/quic_connection.h View 1 chunk +6 lines, -5 lines 0 comments Download
M net/quic/core/quic_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_connection_test.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M net/quic/core/quic_headers_stream.h View 3 chunks +12 lines, -10 lines 0 comments Download
M net/quic/core/quic_headers_stream.cc View 5 chunks +14 lines, -11 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M net/quic/core/quic_packet_creator.h View 2 chunks +9 lines, -8 lines 0 comments Download
M net/quic/core/quic_packet_creator.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/core/quic_packet_generator.h View 1 chunk +15 lines, -12 lines 0 comments Download
M net/quic/core/quic_packet_generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_session_test.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M net/quic/core/quic_spdy_session.h View 1 chunk +6 lines, -5 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_spdy_stream.h View 2 chunks +13 lines, -9 lines 0 comments Download
M net/quic/core/quic_spdy_stream.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/core/quic_stream.h View 3 chunks +12 lines, -9 lines 0 comments Download
M net/quic/core/quic_stream.cc View 5 chunks +14 lines, -9 lines 0 comments Download
M net/quic/core/quic_stream_test.cc View 7 chunks +12 lines, -11 lines 0 comments Download
M net/quic/quartc/quartc_stream_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_peer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_peer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 5 chunks +19 lines, -16 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 7 chunks +34 lines, -36 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 9 chunks +22 lines, -20 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 3 chunks +14 lines, -15 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 3 chunks +17 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
Fan Yang
4 years ago (2016-12-19 16:54:09 UTC) #5
Ryan Hamilton
lgtm
4 years ago (2016-12-19 19:18:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580393003/1
4 years ago (2016-12-19 19:34:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 19:40:55 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-19 19:42:58 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bc4ec0dac01c4b68221ea3a29db4cd47abac170
Cr-Commit-Position: refs/heads/master@{#439524}

Powered by Google App Engine
This is Rietveld 408576698