net/quic/quartc/quartc_stream_test.cc - Issue 2588043002: Pass value and use std::move instead of const reference for ack listeners.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quartc/quartc_stream_test.cc

Issue 2588043002: Pass value and use std::move instead of const reference for ack listeners. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quartc/quartc_stream_test.cc

diff --git a/net/quic/quartc/quartc_stream_test.cc b/net/quic/quartc/quartc_stream_test.cc

index 506a90dda4d57de787484f3b80c23e89ac2e38b3..fdafe221c389e11a88b91920a0c76c051e8640ba 100644

--- a/net/quic/quartc/quartc_stream_test.cc

+++ b/net/quic/quartc/quartc_stream_test.cc

@@ -38,7 +38,7 @@ class MockQuicSession : public QuicSession {

QuicIOVector iovector,

QuicStreamOffset offset,

bool fin,

- const scoped_refptr<QuicAckListenerInterface>& /*ack_notifier_delegate*/)

+ scoped_refptr<QuicAckListenerInterface> /*ack_notifier_delegate*/)

override {

if (!writable_) {

return QuicConsumedData(0, false);

« no previous file with comments | « net/quic/core/quic_stream.cc ('k') | net/quic/test_tools/quic_stream_peer.h » ('j') | no next file with comments »