Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: net/quic/core/quic_session_test.cc

Issue 2588043002: Pass value and use std::move instead of const reference for ack listeners. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_session.cc ('k') | net/quic/core/quic_spdy_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_session_test.cc
diff --git a/net/quic/core/quic_session_test.cc b/net/quic/core/quic_session_test.cc
index 4e1479dea127e32eaefb957d29aefd334fff8520..fa21afe7cef81bc25172799b8aebd1592c8b6d68 100644
--- a/net/quic/core/quic_session_test.cc
+++ b/net/quic/core/quic_session_test.cc
@@ -162,17 +162,17 @@ class TestSession : public QuicSpdySession {
return QuicSpdySession::GetOrCreateDynamicStream(stream_id);
}
- QuicConsumedData WritevData(QuicStream* stream,
- QuicStreamId id,
- QuicIOVector data,
- QuicStreamOffset offset,
- bool fin,
- const scoped_refptr<QuicAckListenerInterface>&
- ack_notifier_delegate) override {
+ QuicConsumedData WritevData(
+ QuicStream* stream,
+ QuicStreamId id,
+ QuicIOVector data,
+ QuicStreamOffset offset,
+ bool fin,
+ scoped_refptr<QuicAckListenerInterface> ack_notifier_delegate) override {
QuicConsumedData consumed(data.total_length, fin);
if (!writev_consumes_all_data_) {
consumed = QuicSession::WritevData(stream, id, data, offset, fin,
- ack_notifier_delegate);
+ std::move(ack_notifier_delegate));
}
stream->set_stream_bytes_written(stream->stream_bytes_written() +
consumed.bytes_consumed);
« no previous file with comments | « net/quic/core/quic_session.cc ('k') | net/quic/core/quic_spdy_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698