Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Issue 2589983002: Create a QUIC wrapper around scoped_refptr. (Closed)

Created:
4 years ago by Fan Yang
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create a QUIC wrapper around scoped_refptr. Merge internal change 142469678. BUG= Committed: https://crrev.com/0aa8bc296a1f61163afe103a8119561a7306410a Cr-Commit-Position: refs/heads/master@{#439919}

Patch Set 1 #

Patch Set 2 : delete unnecessary includes #

Patch Set 3 : rebase #

Patch Set 4 : = nullptr #

Patch Set 5 : rm QUIC_EXPORT_PRIVATE from template classes #

Patch Set 6 : initialize chain in UncompressedCerts() #

Patch Set 7 : rm = nullptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1024 lines, -480 lines) Patch
M net/net.gypi View 3 chunks +3 lines, -0 lines 0 comments Download
M net/quic/chromium/crypto/proof_source_chromium.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/chromium/crypto/proof_source_chromium.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/chromium/crypto/proof_test_chromium.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.h View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_client_stream_test.cc View 2 chunks +22 lines, -20 lines 0 comments Download
M net/quic/core/crypto/crypto_handshake.h View 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/core/crypto/crypto_server_test.cc View 5 chunks +16 lines, -14 lines 0 comments Download
M net/quic/core/crypto/proof_source.h View 1 4 chunks +7 lines, -8 lines 0 comments Download
M net/quic/core/crypto/quic_compressed_certs_cache.h View 1 5 chunks +8 lines, -8 lines 0 comments Download
M net/quic/core/crypto/quic_compressed_certs_cache.cc View 1 2 3 4 5 3 chunks +5 lines, -4 lines 0 comments Download
M net/quic/core/crypto/quic_compressed_certs_cache_test.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.h View 6 chunks +6 lines, -5 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config_test.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.h View 17 chunks +61 lines, -61 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 33 chunks +81 lines, -68 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config_test.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M net/quic/core/crypto/quic_server_info.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_ack_listener_interface.h View 2 chunks +7 lines, -8 lines 0 comments Download
M net/quic/core/quic_ack_listener_interface.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/core/quic_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_connection.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 7 chunks +9 lines, -7 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.h View 4 chunks +6 lines, -4 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_crypto_stream.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_headers_stream.h View 3 chunks +8 lines, -7 lines 0 comments Download
M net/quic/core/quic_headers_stream.cc View 4 5 6 5 chunks +10 lines, -7 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/core/quic_packet_creator.h View 2 chunks +6 lines, -5 lines 0 comments Download
M net/quic/core/quic_packet_creator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_packet_generator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_packet_generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_packets.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_session.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_session.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_session_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_spdy_session.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_spdy_session.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_spdy_stream.h View 2 chunks +10 lines, -7 lines 0 comments Download
M net/quic/core/quic_spdy_stream.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M net/quic/core/quic_stream.h View 7 chunks +12 lines, -9 lines 0 comments Download
M net/quic/core/quic_stream.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M net/quic/core/quic_stream_test.cc View 8 chunks +19 lines, -13 lines 0 comments Download
A net/quic/platform/api/quic_reference_counted.h View 1 2 3 4 1 chunk +161 lines, -0 lines 0 comments Download
A net/quic/platform/api/quic_reference_counted_test.cc View 1 chunk +173 lines, -0 lines 0 comments Download
M net/quic/platform/impl/quic_mutex_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
A net/quic/platform/impl/quic_reference_counted_impl.h View 1 2 3 4 1 chunk +114 lines, -0 lines 0 comments Download
M net/quic/quartc/quartc_session.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M net/quic/quartc/quartc_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quartc/quartc_stream_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 6 chunks +18 lines, -14 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils_test.cc View 5 chunks +16 lines, -12 lines 0 comments Download
M net/quic/test_tools/fake_proof_source.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/fake_proof_source.cc View 3 chunks +11 lines, -10 lines 0 comments Download
M net/quic/test_tools/quic_crypto_server_config_peer.h View 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_crypto_server_config_peer.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M net/quic/test_tools/quic_stream_peer.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_peer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 4 chunks +31 lines, -27 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 3 chunks +14 lines, -12 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 2 chunks +22 lines, -20 lines 0 comments Download
M net/tools/quic/stateless_rejector.h View 2 chunks +4 lines, -3 lines 0 comments Download
M net/tools/quic/stateless_rejector.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 4 chunks +12 lines, -10 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 35 (30 generated)
Fan Yang
4 years ago (2016-12-20 18:37:13 UTC) #25
Ryan Hamilton
lgtm
4 years ago (2016-12-20 19:00:21 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589983002/120001
4 years ago (2016-12-20 22:05:17 UTC) #30
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years ago (2016-12-20 23:19:59 UTC) #33
commit-bot: I haz the power
4 years ago (2016-12-20 23:21:40 UTC) #35
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/0aa8bc296a1f61163afe103a8119561a7306410a
Cr-Commit-Position: refs/heads/master@{#439919}

Powered by Google App Engine
This is Rietveld 408576698