Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: net/tools/quic/test_tools/quic_test_client.h

Issue 2588043002: Pass value and use std::move instead of const reference for ack listeners. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_simple_server_stream_test.cc ('k') | net/tools/quic/test_tools/quic_test_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/test_tools/quic_test_client.h
diff --git a/net/tools/quic/test_tools/quic_test_client.h b/net/tools/quic/test_tools/quic_test_client.h
index 04cc791bc1e7e9d821d1a8a74f98d97e219df2dd..49991efd6ec0b0d0dd5c88ba6b6ba2941af30225 100644
--- a/net/tools/quic/test_tools/quic_test_client.h
+++ b/net/tools/quic/test_tools/quic_test_client.h
@@ -115,7 +115,7 @@ class QuicTestClient : public QuicSpdyStream::Visitor,
// As above, but |delegate| will be notified when |data| is ACKed.
ssize_t SendData(const std::string& data,
bool last_data,
- const scoped_refptr<QuicAckListenerInterface>& delegate);
+ scoped_refptr<QuicAckListenerInterface> delegate);
// Clears any outstanding state and sends a simple GET of 'uri' to the
// server. Returns 0 if the request failed and no bytes were written.
@@ -219,7 +219,7 @@ class QuicTestClient : public QuicSpdyStream::Visitor,
const SpdyHeaderBlock* headers,
base::StringPiece body,
bool fin,
- const scoped_refptr<QuicAckListenerInterface>& delegate);
+ scoped_refptr<QuicAckListenerInterface> delegate);
QuicRstStreamErrorCode stream_error() { return stream_error_; }
QuicErrorCode connection_error();
@@ -276,12 +276,11 @@ class QuicTestClient : public QuicSpdyStream::Visitor,
private:
class TestClientDataToResend : public QuicClient::QuicDataToResend {
public:
- TestClientDataToResend(
- std::unique_ptr<SpdyHeaderBlock> headers,
- base::StringPiece body,
- bool fin,
- QuicTestClient* test_client,
- const scoped_refptr<QuicAckListenerInterface>& delegate);
+ TestClientDataToResend(std::unique_ptr<SpdyHeaderBlock> headers,
+ base::StringPiece body,
+ bool fin,
+ QuicTestClient* test_client,
+ scoped_refptr<QuicAckListenerInterface> delegate);
~TestClientDataToResend() override;
« no previous file with comments | « net/tools/quic/quic_simple_server_stream_test.cc ('k') | net/tools/quic/test_tools/quic_test_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698