Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: net/quic/core/quic_headers_stream.cc

Issue 2588043002: Pass value and use std::move instead of const reference for ack listeners. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_headers_stream.h ('k') | net/quic/core/quic_packet_creator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_headers_stream.cc
diff --git a/net/quic/core/quic_headers_stream.cc b/net/quic/core/quic_headers_stream.cc
index 176211669ae8ef0252daa379e654d1489311fd80..0e64661871ac787837c483a7692e7f9d2f289d42 100644
--- a/net/quic/core/quic_headers_stream.cc
+++ b/net/quic/core/quic_headers_stream.cc
@@ -344,7 +344,7 @@ size_t QuicHeadersStream::WriteHeaders(
SpdyHeaderBlock headers,
bool fin,
SpdyPriority priority,
- const scoped_refptr<QuicAckListenerInterface>& ack_listener) {
+ scoped_refptr<QuicAckListenerInterface> ack_listener) {
SpdyHeadersIR headers_frame(stream_id, std::move(headers));
headers_frame.set_fin(fin);
if (session()->perspective() == Perspective::IS_CLIENT) {
@@ -353,7 +353,7 @@ size_t QuicHeadersStream::WriteHeaders(
}
SpdySerializedFrame frame(spdy_framer_.SerializeFrame(headers_frame));
WriteOrBufferData(StringPiece(frame.data(), frame.size()), false,
- ack_listener);
+ std::move(ack_listener));
return frame.size();
}
@@ -381,19 +381,19 @@ void QuicHeadersStream::WriteDataFrame(
QuicStreamId id,
StringPiece data,
bool fin,
- const scoped_refptr<QuicAckListenerInterface>& ack_notifier_delegate) {
+ scoped_refptr<QuicAckListenerInterface> ack_notifier_delegate) {
SpdyDataIR spdy_data(id, data);
spdy_data.set_fin(fin);
SpdySerializedFrame frame(spdy_framer_.SerializeFrame(spdy_data));
scoped_refptr<ForceHolAckListener> ack_listener;
if (ack_notifier_delegate != nullptr) {
- ack_listener = new ForceHolAckListener(ack_notifier_delegate,
+ ack_listener = new ForceHolAckListener(std::move(ack_notifier_delegate),
frame.size() - data.length());
}
// Use buffered writes so that coherence of framing is preserved
// between streams.
WriteOrBufferData(StringPiece(frame.data(), frame.size()), false,
- ack_listener);
+ std::move(ack_listener));
}
QuicConsumedData QuicHeadersStream::WritevStreamData(
@@ -401,7 +401,7 @@ QuicConsumedData QuicHeadersStream::WritevStreamData(
QuicIOVector iov,
QuicStreamOffset offset,
bool fin,
- const scoped_refptr<QuicAckListenerInterface>& ack_notifier_delegate) {
+ scoped_refptr<QuicAckListenerInterface> ack_notifier_delegate) {
const size_t max_len =
kSpdyInitialFrameSizeLimit - SpdyConstants::kDataFrameMinimumSize;
@@ -409,7 +409,7 @@ QuicConsumedData QuicHeadersStream::WritevStreamData(
size_t total_length = iov.total_length;
if (total_length == 0 && fin) {
- WriteDataFrame(id, StringPiece(), true, ack_notifier_delegate);
+ WriteDataFrame(id, StringPiece(), true, std::move(ack_notifier_delegate));
result.fin_consumed = true;
return result;
}
« no previous file with comments | « net/quic/core/quic_headers_stream.h ('k') | net/quic/core/quic_packet_creator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698