Pass InteractionStats by value

Pass InteractionStats by value

The APIs related to PasswordStore currently pass vectors of unique_ptrs of
InteractionStats. Thanks to C++11 move semantics it is no performance hit to
pass around vectors of the stats themselves, leading to a simpler API. This CL
drops the unique_ptr part.

BUG=621355
Committed: https://crrev.com/d2b56a83f852409c53119aa2604daf674d005b63
Cr-Commit-Position: refs/heads/master@{#436908}

[vabr (Chromium), 2016-12-06 14:39:23]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 14:39:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 15:26:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 15:26:19]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-12-06 16:03:53]

vabr@chromium.org changed reviewers:
+ vasilii@chromium.org

[vabr (Chromium), 2016-12-06 16:03:54]

Hi Vasilii,

This is a follow-up on your last review.

PTAL.

Thanks!
Vaclav

[vasilii, 2016-12-06 19:36:07]

lgtm

https://codereview.chromium.org/2552263002/diff/1/components/password_manager...
File components/password_manager/core/browser/form_fetcher_impl_unittest.cc
(right):

https://codereview.chromium.org/2552263002/diff/1/components/password_manager...
components/password_manager/core/browser/form_fetcher_impl_unittest.cc:346:
std::vector<InteractionsStats> db_stats;
std::vector<InteractionsStats> db_stats = { stats };

[vabr (Chromium), 2016-12-07 09:10:17]

Thanks!

https://codereview.chromium.org/2552263002/diff/1/components/password_manager...
File components/password_manager/core/browser/form_fetcher_impl_unittest.cc
(right):

https://codereview.chromium.org/2552263002/diff/1/components/password_manager...
components/password_manager/core/browser/form_fetcher_impl_unittest.cc:346:
std::vector<InteractionsStats> db_stats;
On 2016/12/06 19:36:06, vasilii wrote:
> std::vector<InteractionsStats> db_stats = { stats };

Done.
I am still learning the rules for this, but seems like this falls in the 1st
category mentioned by
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts?pli=1#TOC-....

[vabr (Chromium), 2016-12-07 09:10:21]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-12-07 09:10:22]

The patchset sent to the CQ was uploaded after l-g-t-m from vasilii@chromium.org
Link to the patchset: https://codereview.chromium.org/2552263002/#ps20001
(title: "={}")

[commit-bot: I haz the power, 2016-12-07 09:10:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 10:28:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481101821761140,
"parent_rev": "65e7bb3b4ced9490b2f7c42dd52b44e54ba892e5", "commit_rev":
"82daeb378a48be0520fcc9cdb43a876236865c5d"}

[commit-bot: I haz the power, 2016-12-07 10:29:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 10:30:45]

Description was changed from

==========
Pass InteractionStats by value

The APIs related to PasswordStore currently pass vectors of unique_ptrs of
InteractionStats. Thanks to C++11 move semantics it is no performance hit to
pass around vectors of the stats themselves, leading to a simpler API. This CL
drops the unique_ptr part.

BUG=621355
==========

to

==========
Pass InteractionStats by value

The APIs related to PasswordStore currently pass vectors of unique_ptrs of
InteractionStats. Thanks to C++11 move semantics it is no performance hit to
pass around vectors of the stats themselves, leading to a simpler API. This CL
drops the unique_ptr part.

BUG=621355

Committed: https://crrev.com/d2b56a83f852409c53119aa2604daf674d005b63
Cr-Commit-Position: refs/heads/master@{#436908}
==========

[commit-bot: I haz the power, 2016-12-07 10:30:46]

Patchset 2 (id:??) landed as
https://crrev.com/d2b56a83f852409c53119aa2604daf674d005b63
Cr-Commit-Position: refs/heads/master@{#436908}