Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: components/password_manager/core/browser/fake_form_fetcher.h

Issue 2552263002: Pass InteractionStats by value (Closed)
Patch Set: ={} Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/fake_form_fetcher.h
diff --git a/components/password_manager/core/browser/fake_form_fetcher.h b/components/password_manager/core/browser/fake_form_fetcher.h
index e8d6f139695a54da6b1c3c63766558f257ec91be..93fa7e398460a209c21899490f61acdcc5fc0b53 100644
--- a/components/password_manager/core/browser/fake_form_fetcher.h
+++ b/components/password_manager/core/browser/fake_form_fetcher.h
@@ -10,6 +10,7 @@
#include "base/macros.h"
#include "components/password_manager/core/browser/form_fetcher.h"
+#include "components/password_manager/core/browser/statistics_table.h"
namespace autofill {
struct PasswordForm;
@@ -37,10 +38,9 @@ class FakeFormFetcher : public FormFetcher {
State GetState() const override;
// Statistics for recent password bubble usage.
- const std::vector<const InteractionsStats*>& GetInteractionsStats()
- const override;
+ const std::vector<InteractionsStats>& GetInteractionsStats() const override;
- void set_stats(const std::vector<const InteractionsStats*>& stats) {
+ void set_stats(const std::vector<InteractionsStats>& stats) {
state_ = State::NOT_WAITING;
stats_ = stats;
}
@@ -64,7 +64,7 @@ class FakeFormFetcher : public FormFetcher {
private:
std::set<Consumer*> consumers_;
State state_ = State::NOT_WAITING;
- std::vector<const InteractionsStats*> stats_;
+ std::vector<InteractionsStats> stats_;
std::vector<const autofill::PasswordForm*> federated_;
DISALLOW_COPY_AND_ASSIGN(FakeFormFetcher);

Powered by Google App Engine
This is Rietveld 408576698