Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: components/password_manager/core/browser/password_store.h

Issue 2552263002: Pass InteractionStats by value (Closed)
Patch Set: ={} Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store.h
diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h
index fe0ec7acf85c39aa3ea8dfa97f747d66fa18ede3..28a7046526cb8a086dae46c17f6c107322424379 100644
--- a/components/password_manager/core/browser/password_store.h
+++ b/components/password_manager/core/browser/password_store.h
@@ -240,8 +240,7 @@ class PasswordStore : protected PasswordStoreSync,
void NotifyConsumerWithResults(
std::vector<std::unique_ptr<autofill::PasswordForm>> results);
- void NotifyWithSiteStatistics(
- std::vector<std::unique_ptr<InteractionsStats>> stats);
+ void NotifyWithSiteStatistics(std::vector<InteractionsStats> stats);
void set_ignore_logins_cutoff(base::Time cutoff) {
ignore_logins_cutoff_ = cutoff;
@@ -326,7 +325,7 @@ class PasswordStore : protected PasswordStoreSync,
// Synchronous implementation for manipulating with statistics.
virtual void AddSiteStatsImpl(const InteractionsStats& stats) = 0;
virtual void RemoveSiteStatsImpl(const GURL& origin_domain) = 0;
- virtual std::vector<std::unique_ptr<InteractionsStats>> GetSiteStatsImpl(
+ virtual std::vector<InteractionsStats> GetSiteStatsImpl(
const GURL& origin_domain) = 0;
// Log UMA stats for number of bulk deletions.

Powered by Google App Engine
This is Rietveld 408576698