Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: components/password_manager/core/browser/form_fetcher_impl.cc

Issue 2552263002: Pass InteractionStats by value (Closed)
Patch Set: ={} Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/form_fetcher_impl.cc
diff --git a/components/password_manager/core/browser/form_fetcher_impl.cc b/components/password_manager/core/browser/form_fetcher_impl.cc
index f40d40b833b5de4146c48c73e1245400d31d80f7..493e44edf8b2cbd1a487b8c5012ba03b5506b021 100644
--- a/components/password_manager/core/browser/form_fetcher_impl.cc
+++ b/components/password_manager/core/browser/form_fetcher_impl.cc
@@ -75,9 +75,9 @@ FormFetcherImpl::State FormFetcherImpl::GetState() const {
return state_;
}
-const std::vector<const InteractionsStats*>&
-FormFetcherImpl::GetInteractionsStats() const {
- return weak_interactions_stats_;
+const std::vector<InteractionsStats>& FormFetcherImpl::GetInteractionsStats()
+ const {
+ return interactions_stats_;
}
const std::vector<const autofill::PasswordForm*>&
@@ -123,11 +123,10 @@ void FormFetcherImpl::OnGetPasswordStoreResults(
}
void FormFetcherImpl::OnGetSiteStatistics(
- std::vector<std::unique_ptr<InteractionsStats>> stats) {
+ std::vector<InteractionsStats> stats) {
// On Windows the password request may be resolved after the statistics due to
// importing from IE.
interactions_stats_ = std::move(stats);
- weak_interactions_stats_ = MakeWeakCopies(interactions_stats_);
}
void FormFetcherImpl::Fetch() {

Powered by Google App Engine
This is Rietveld 408576698