Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: chrome/browser/password_manager/password_store_proxy_mac.h

Issue 2552263002: Pass InteractionStats by value (Closed)
Patch Set: ={} Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_PROXY_MAC_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_PROXY_MAC_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_PROXY_MAC_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_PROXY_MAC_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 base::Time delete_end) override; 93 base::Time delete_end) override;
94 std::vector<std::unique_ptr<autofill::PasswordForm>> FillMatchingLogins( 94 std::vector<std::unique_ptr<autofill::PasswordForm>> FillMatchingLogins(
95 const FormDigest& form) override; 95 const FormDigest& form) override;
96 bool FillAutofillableLogins( 96 bool FillAutofillableLogins(
97 std::vector<std::unique_ptr<autofill::PasswordForm>>* forms) override; 97 std::vector<std::unique_ptr<autofill::PasswordForm>>* forms) override;
98 bool FillBlacklistLogins( 98 bool FillBlacklistLogins(
99 std::vector<std::unique_ptr<autofill::PasswordForm>>* forms) override; 99 std::vector<std::unique_ptr<autofill::PasswordForm>>* forms) override;
100 void AddSiteStatsImpl( 100 void AddSiteStatsImpl(
101 const password_manager::InteractionsStats& stats) override; 101 const password_manager::InteractionsStats& stats) override;
102 void RemoveSiteStatsImpl(const GURL& origin_domain) override; 102 void RemoveSiteStatsImpl(const GURL& origin_domain) override;
103 std::vector<std::unique_ptr<password_manager::InteractionsStats>> 103 std::vector<password_manager::InteractionsStats> GetSiteStatsImpl(
104 GetSiteStatsImpl(const GURL& origin_domain) override; 104 const GURL& origin_domain) override;
105 105
106 scoped_refptr<SimplePasswordStoreMac> password_store_simple_; 106 scoped_refptr<SimplePasswordStoreMac> password_store_simple_;
107 107
108 // The login metadata SQL database. If opening the DB on |thread_| fails, 108 // The login metadata SQL database. If opening the DB on |thread_| fails,
109 // |login_metadata_db_| will be reset to NULL for the lifetime of |this|. 109 // |login_metadata_db_| will be reset to NULL for the lifetime of |this|.
110 // The ownership may be transferred to |password_store_simple_|. 110 // The ownership may be transferred to |password_store_simple_|.
111 std::unique_ptr<password_manager::LoginDatabase> login_metadata_db_; 111 std::unique_ptr<password_manager::LoginDatabase> login_metadata_db_;
112 112
113 // Keychain wrapper. 113 // Keychain wrapper.
114 const std::unique_ptr<crypto::AppleKeychain> keychain_; 114 const std::unique_ptr<crypto::AppleKeychain> keychain_;
115 115
116 // Thread that the synchronous methods are run on. 116 // Thread that the synchronous methods are run on.
117 std::unique_ptr<base::Thread> thread_; 117 std::unique_ptr<base::Thread> thread_;
118 118
119 // Current migration status for the profile. 119 // Current migration status for the profile.
120 IntegerPrefMember migration_status_; 120 IntegerPrefMember migration_status_;
121 121
122 // List of tasks filled by InitOnBackgroundThread. They can't be just posted 122 // List of tasks filled by InitOnBackgroundThread. They can't be just posted
123 // to the UI thread because the message loop can shut down before executing 123 // to the UI thread because the message loop can shut down before executing
124 // them. If this is the case then Shutdown() flushes the tasks after stopping 124 // them. If this is the case then Shutdown() flushes the tasks after stopping
125 // the background thread. 125 // the background thread.
126 // After InitOnBackgroundThread is run once, the queue may not be modified on 126 // After InitOnBackgroundThread is run once, the queue may not be modified on
127 // the background thread any more. 127 // the background thread any more.
128 std::vector<base::Closure> pending_ui_tasks_; 128 std::vector<base::Closure> pending_ui_tasks_;
129 129
130 DISALLOW_COPY_AND_ASSIGN(PasswordStoreProxyMac); 130 DISALLOW_COPY_AND_ASSIGN(PasswordStoreProxyMac);
131 }; 131 };
132 132
133 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_PROXY_MAC_H_ 133 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_PROXY_MAC_H_
OLDNEW
« no previous file with comments | « chrome/browser/password_manager/password_store_mac.cc ('k') | chrome/browser/password_manager/password_store_proxy_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698