Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: components/password_manager/core/browser/mock_password_store.h

Issue 2552263002: Pass InteractionStats by value (Closed)
Patch Set: ={} Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/mock_password_store.h
diff --git a/components/password_manager/core/browser/mock_password_store.h b/components/password_manager/core/browser/mock_password_store.h
index 9975a2cbcb95ae6a241c8d7b70759bee27bff0db..0e6c9d131d3e193385c1709a11ee877113fc74b8 100644
--- a/components/password_manager/core/browser/mock_password_store.h
+++ b/components/password_manager/core/browser/mock_password_store.h
@@ -59,10 +59,8 @@ class MockPasswordStore : public PasswordStore {
MOCK_METHOD1(FillBlacklistLogins,
bool(std::vector<std::unique_ptr<autofill::PasswordForm>>*));
MOCK_METHOD1(NotifyLoginsChanged, void(const PasswordStoreChangeList&));
- // GMock doesn't allow to return noncopyable types.
- std::vector<std::unique_ptr<InteractionsStats>> GetSiteStatsImpl(
- const GURL& origin_domain) override;
- MOCK_METHOD1(GetSiteStatsMock, std::vector<InteractionsStats*>(const GURL&));
+ MOCK_METHOD1(GetSiteStatsImpl,
+ std::vector<InteractionsStats>(const GURL& origin_domain));
MOCK_METHOD1(AddSiteStatsImpl, void(const InteractionsStats&));
MOCK_METHOD1(RemoveSiteStatsImpl, void(const GURL&));

Powered by Google App Engine
This is Rietveld 408576698