Pass InteractionStats by value

components/password_manager/core/browser/statistics_table.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/statistics_table.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <limits>
@@ skipping 19 matching lines @@
 InteractionsStats::InteractionsStats() = default;
 
 bool operator==(const InteractionsStats& lhs, const InteractionsStats& rhs) {
   return lhs.origin_domain == rhs.origin_domain &&
          lhs.username_value == rhs.username_value &&
          lhs.dismissal_count == rhs.dismissal_count &&
          lhs.update_time == rhs.update_time;
 }
 
 const InteractionsStats* FindStatsByUsername(
-    const std::vector<const InteractionsStats*>& stats,
+    const std::vector<InteractionsStats>& stats,
     const base::string16& username) {
   auto it = std::find_if(stats.begin(), stats.end(),
-                         [&username](const InteractionsStats* element) {
-                           return username == element->username_value;
+                         [&username](const InteractionsStats& element) {
+                           return username == element.username_value;
                          });
-  return it == stats.end() ? nullptr : *it;
+  return it == stats.end() ? nullptr : &*it;
 }
 
 StatisticsTable::StatisticsTable() : db_(nullptr) {
 }
 
 StatisticsTable::~StatisticsTable() = default;
 
 void StatisticsTable::Init(sql::Connection* db) {
   db_ = db;
 }
@@ skipping 42 matching lines @@
 bool StatisticsTable::RemoveRow(const GURL& domain) {
   if (!domain.is_valid())
     return false;
   sql::Statement s(db_->GetCachedStatement(SQL_FROM_HERE,
                                            "DELETE FROM stats WHERE "
                                            "origin_domain = ? "));
   s.BindString(0, domain.spec());
   return s.Run();
 }
 
-std::vector<std::unique_ptr<InteractionsStats>> StatisticsTable::GetRows(
-    const GURL& domain) {
+std::vector<InteractionsStats> StatisticsTable::GetRows(const GURL& domain) {
   if (!domain.is_valid())
-    return std::vector<std::unique_ptr<InteractionsStats>>();
+    return std::vector<InteractionsStats>();
   const char query[] =
       "SELECT origin_domain, username_value, "
       "dismissal_count, update_time FROM stats WHERE origin_domain == ?";
   sql::Statement s(db_->GetCachedStatement(SQL_FROM_HERE, query));
   s.BindString(0, domain.spec());
-  std::vector<std::unique_ptr<InteractionsStats>> result;
+  std::vector<InteractionsStats> result;
   while (s.Step()) {
-    result.push_back(base::WrapUnique(new InteractionsStats));
-    result.back()->origin_domain = GURL(s.ColumnString(COLUMN_ORIGIN_DOMAIN));
-    result.back()->username_value = s.ColumnString16(COLUMN_USERNAME);
-    result.back()->dismissal_count = s.ColumnInt(COLUMN_DISMISSALS);
-    result.back()->update_time =
+    result.push_back(InteractionsStats());
+    result.back().origin_domain = GURL(s.ColumnString(COLUMN_ORIGIN_DOMAIN));
+    result.back().username_value = s.ColumnString16(COLUMN_USERNAME);
+    result.back().dismissal_count = s.ColumnInt(COLUMN_DISMISSALS);
+    result.back().update_time =
         base::Time::FromInternalValue(s.ColumnInt64(COLUMN_DATE));
   }
   return result;
 }
 
 bool StatisticsTable::RemoveStatsByOriginAndTime(
     const base::Callback<bool(const GURL&)>& origin_filter,
     base::Time delete_begin,
     base::Time delete_end) {
   if (delete_end.is_null())
@@ skipping 36 matching lines @@
     origin_delete_statement.BindString(0, origin);
     origin_delete_statement.BindInt64(1, delete_begin.ToInternalValue());
     origin_delete_statement.BindInt64(2, delete_end.ToInternalValue());
     success = success && origin_delete_statement.Run();
   }
 
   return success;
 }
 
 }  // namespace password_manager