components/password_manager/core/browser/form_fetcher.h - Issue 2552263002: Pass InteractionStats by value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/form_fetcher.h

Issue 2552263002: Pass InteractionStats by value (Closed)

Patch Set: ={} Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/form_fetcher.h

diff --git a/components/password_manager/core/browser/form_fetcher.h b/components/password_manager/core/browser/form_fetcher.h

index 145a56580b1fff1cba18bdbc08ceb1502262357a..e2e16423c7f3f00ca91e695a7e957b211ea4b301 100644

--- a/components/password_manager/core/browser/form_fetcher.h

+++ b/components/password_manager/core/browser/form_fetcher.h

@@ -60,7 +60,7 @@ class FormFetcher {

virtual State GetState() const = 0;

// Statistics for recent password bubble usage.

- virtual const std::vector<const InteractionsStats*>& GetInteractionsStats()

+ virtual const std::vector<InteractionsStats>& GetInteractionsStats()

const = 0;

// Federated matches obtained from the backend. Valid only if GetState()