components/password_manager/core/browser/password_store_consumer.h - Issue 2552263002: Pass InteractionStats by value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_consumer.h

Issue 2552263002: Pass InteractionStats by value (Closed)

Patch Set: ={} Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_store_consumer.h

diff --git a/components/password_manager/core/browser/password_store_consumer.h b/components/password_manager/core/browser/password_store_consumer.h

index f137225be67081f5bf386f18a7088bafcc9e372f..89d7975d0ee3d64cf43797d615f3b62a46beced3 100644

--- a/components/password_manager/core/browser/password_store_consumer.h

+++ b/components/password_manager/core/browser/password_store_consumer.h

@@ -34,8 +34,7 @@ class PasswordStoreConsumer {

// Called when the GetLogins() request is finished, with the associated site

// statistics.

- virtual void OnGetSiteStatistics(

- std::vector<std::unique_ptr<InteractionsStats>> stats);

+ virtual void OnGetSiteStatistics(std::vector<InteractionsStats> stats);

// The base::CancelableTaskTracker can be used for cancelling the

// tasks associated with the consumer.