Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: chrome/browser/password_manager/password_store_mac.h

Issue 2552263002: Pass InteractionStats by value (Closed)
Patch Set: ={} Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_store_mac.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_MAC_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_MAC_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_MAC_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_MAC_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 base::Time delete_end) override; 105 base::Time delete_end) override;
106 std::vector<std::unique_ptr<autofill::PasswordForm>> FillMatchingLogins( 106 std::vector<std::unique_ptr<autofill::PasswordForm>> FillMatchingLogins(
107 const FormDigest& form) override; 107 const FormDigest& form) override;
108 bool FillAutofillableLogins( 108 bool FillAutofillableLogins(
109 std::vector<std::unique_ptr<autofill::PasswordForm>>* forms) override; 109 std::vector<std::unique_ptr<autofill::PasswordForm>>* forms) override;
110 bool FillBlacklistLogins( 110 bool FillBlacklistLogins(
111 std::vector<std::unique_ptr<autofill::PasswordForm>>* forms) override; 111 std::vector<std::unique_ptr<autofill::PasswordForm>>* forms) override;
112 void AddSiteStatsImpl( 112 void AddSiteStatsImpl(
113 const password_manager::InteractionsStats& stats) override; 113 const password_manager::InteractionsStats& stats) override;
114 void RemoveSiteStatsImpl(const GURL& origin_domain) override; 114 void RemoveSiteStatsImpl(const GURL& origin_domain) override;
115 std::vector<std::unique_ptr<password_manager::InteractionsStats>> 115 std::vector<password_manager::InteractionsStats> GetSiteStatsImpl(
116 GetSiteStatsImpl(const GURL& origin_domain) override; 116 const GURL& origin_domain) override;
117 117
118 // Adds the given form to the Keychain if it's something we want to store 118 // Adds the given form to the Keychain if it's something we want to store
119 // there (i.e., not a blacklist entry or a federated login). Returns true if 119 // there (i.e., not a blacklist entry or a federated login). Returns true if
120 // the operation succeeded (either we added successfully, or we didn't need 120 // the operation succeeded (either we added successfully, or we didn't need
121 // to). 121 // to).
122 bool AddToKeychainIfNecessary(const autofill::PasswordForm& form); 122 bool AddToKeychainIfNecessary(const autofill::PasswordForm& form);
123 123
124 // Returns true if our database contains a form that exactly matches the given 124 // Returns true if our database contains a form that exactly matches the given
125 // keychain form. 125 // keychain form.
126 bool DatabaseHasFormMatchingKeychainForm( 126 bool DatabaseHasFormMatchingKeychainForm(
(...skipping 15 matching lines...) Expand all
142 std::unique_ptr<crypto::AppleKeychain> keychain_; 142 std::unique_ptr<crypto::AppleKeychain> keychain_;
143 143
144 // The login metadata SQL database. The caller is resonsible for initializing 144 // The login metadata SQL database. The caller is resonsible for initializing
145 // it. 145 // it.
146 password_manager::LoginDatabase* login_metadata_db_; 146 password_manager::LoginDatabase* login_metadata_db_;
147 147
148 DISALLOW_COPY_AND_ASSIGN(PasswordStoreMac); 148 DISALLOW_COPY_AND_ASSIGN(PasswordStoreMac);
149 }; 149 };
150 150
151 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_MAC_H_ 151 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_MAC_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_store_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698