Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed)

Created:
6 years, 8 months ago by not at google - send to devlin
Modified:
6 years, 7 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, yoshiki+watch_chromium.org, yukishiino+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, Ilya Sherman, nkostylev+watch_chromium.org, extensions-reviews_chromium.org, jar (doing other things), aboxhall+watch_chromium.org, stevenjb+watch_chromium.org, nona+watch_chromium.org, chromium-apps-reviews_chromium.org, miu+watch_chromium.org, yuzo+watch_chromium.org, nhiroki, oshima+watch_chromium.org, plundblad+watch_chromium.org, asvitkine+watch_chromium.org, benjhayden+dwatch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl function doesn't require divergent return value semantics depending on subclass. BUG=365732 R=rockot@chromium.org TBR=pkasting@chromium.org,dtseng@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267083

Patch Set 1 #

Total comments: 2

Patch Set 2 : chromeos #

Patch Set 3 : rebase #

Patch Set 4 : fix bookmarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+633 lines, -654 lines) Patch
M chrome/browser/accessibility/accessibility_extension_api.h View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/accessibility/accessibility_extension_api.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_api.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.h View 1 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_tasks.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/first_run_private_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/first_run_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/info_private_api.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/info_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/input_method_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/audio/audio_api.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/audio/audio_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/autotest_private/autotest_private_api.h View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/autotest_private/autotest_private_api.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h View 1 20 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 1 16 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.h View 1 13 chunks +32 lines, -29 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 1 2 3 16 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/command_line_private/command_line_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/command_line_private/command_line_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/commands/commands.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/commands/commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/context_menus/context_menus_api.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/context_menus/context_menus_api.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.h View 1 6 chunks +6 lines, -34 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 1 9 chunks +66 lines, -64 lines 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_api.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.h View 1 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 8 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.h View 1 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.h View 1 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/history/history_api.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/history/history_api.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/hotword_private/hotword_private_api.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/hotword_private/hotword_private_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity_private/identity_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity_private/identity_private_api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/idle/idle_api.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/idle/idle_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/idltest/idltest_api.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/idltest/idltest_api.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/input/input.h View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/input/input.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.h View 1 2 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 2 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/location/location_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/location/location_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_api.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/metrics_private/metrics_private_api.h View 13 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/metrics_private/metrics_private_api.cc View 1 11 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/module/module.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/module/module.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_api.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_api_chromeos.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/power/power_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/power/power_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/preference/chrome_direct_setting.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/preference/chrome_direct_setting.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_api.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/principals_private/principals_private_api.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/principals_private/principals_private_api.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/reading_list_private/reading_list_private_api.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/reading_list_private/reading_list_private_api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/system_display/system_display_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/system_display/system_display_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/system_private/system_private_api.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/system_private/system_private_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.h View 1 4 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 18 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/webcam_private/webcam_private_api.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/webcam_private/webcam_private_api_chromeos.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.h View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/chrome_extension_function.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extension_function.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/infobars/infobar_extension_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/infobars/infobar_extension_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M extensions/browser/api/test/test_api.h View 1 8 chunks +17 lines, -15 lines 0 comments Download
M extensions/browser/api/test/test_api.cc View 1 6 chunks +9 lines, -10 lines 0 comments Download
M extensions/browser/extension_function.h View 1 2 3 chunks +9 lines, -5 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M extensions/browser/quota_service_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/252653002/diff/1/extensions/browser/extension_function.h File extensions/browser/extension_function.h (right): https://codereview.chromium.org/252653002/diff/1/extensions/browser/extension_function.h#newcode127 extensions/browser/extension_function.h:127: void Run(); The "Derived classes..." part of this ...
6 years, 8 months ago (2014-04-25 04:01:35 UTC) #1
not at google - send to devlin
I forgot about all of the chromeos APIs. There is a bunch more code now.
6 years, 7 months ago (2014-04-28 22:36:53 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/252653002/diff/1/extensions/browser/extension_function.h File extensions/browser/extension_function.h (right): https://codereview.chromium.org/252653002/diff/1/extensions/browser/extension_function.h#newcode127 extensions/browser/extension_function.h:127: void Run(); On 2014/04/25 04:01:36, Ken Rockot wrote: > ...
6 years, 7 months ago (2014-04-28 22:38:14 UTC) #3
Ken Rockot(use gerrit already)
still lgtm
6 years, 7 months ago (2014-04-29 18:14:02 UTC) #4
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 7 months ago (2014-04-29 18:20:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/252653002/40001
6 years, 7 months ago (2014-04-29 18:22:51 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 18:56:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 18:56:41 UTC) #8
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 7 months ago (2014-04-29 18:58:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/252653002/40001
6 years, 7 months ago (2014-04-29 19:00:23 UTC) #10
not at google - send to devlin
The CQ bit was unchecked by kalman@chromium.org
6 years, 7 months ago (2014-04-29 21:13:18 UTC) #11
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 7 months ago (2014-04-29 22:04:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/252653002/50001
6 years, 7 months ago (2014-04-29 22:08:24 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 05:20:13 UTC) #14
Message was sent while issue was closed. 
Change committed as 267083

Powered by Google App Engine
This is Rietveld 408576698