Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2684)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bookmarks Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
index cfc1077fb4caa55b2b0ded2e94627f1ae5b2fc5e..5f9ce42c067715a70843a29d98ccac44d2a6897b 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
@@ -313,7 +313,7 @@ void DeveloperPrivateAPI::OnListenerRemoved(
namespace api {
-bool DeveloperPrivateAutoUpdateFunction::RunImpl() {
+bool DeveloperPrivateAutoUpdateFunction::RunSync() {
ExtensionUpdater* updater = GetExtensionUpdater(GetProfile());
if (updater)
updater->CheckNow(ExtensionUpdater::CheckParams());
@@ -652,7 +652,7 @@ bool DeveloperPrivateGetItemsInfoFunction::RunImpl() {
DeveloperPrivateGetItemsInfoFunction::~DeveloperPrivateGetItemsInfoFunction() {}
-bool DeveloperPrivateAllowFileAccessFunction::RunImpl() {
+bool DeveloperPrivateAllowFileAccessFunction::RunSync() {
scoped_ptr<AllowFileAccess::Params> params(
AllowFileAccess::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
@@ -683,7 +683,7 @@ bool DeveloperPrivateAllowFileAccessFunction::RunImpl() {
DeveloperPrivateAllowFileAccessFunction::
~DeveloperPrivateAllowFileAccessFunction() {}
-bool DeveloperPrivateAllowIncognitoFunction::RunImpl() {
+bool DeveloperPrivateAllowIncognitoFunction::RunSync() {
scoped_ptr<AllowIncognito::Params> params(
AllowIncognito::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
@@ -703,8 +703,7 @@ bool DeveloperPrivateAllowIncognitoFunction::RunImpl() {
DeveloperPrivateAllowIncognitoFunction::
~DeveloperPrivateAllowIncognitoFunction() {}
-
-bool DeveloperPrivateReloadFunction::RunImpl() {
+bool DeveloperPrivateReloadFunction::RunSync() {
scoped_ptr<Reload::Params> params(Reload::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
@@ -714,7 +713,7 @@ bool DeveloperPrivateReloadFunction::RunImpl() {
return true;
}
-bool DeveloperPrivateShowPermissionsDialogFunction::RunImpl() {
+bool DeveloperPrivateShowPermissionsDialogFunction::RunSync() {
EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &extension_id_));
ExtensionService* service = GetProfile()->GetExtensionService();
CHECK(!extension_id_.empty());
@@ -771,7 +770,7 @@ DeveloperPrivateShowPermissionsDialogFunction::
DeveloperPrivateEnableFunction::DeveloperPrivateEnableFunction() {}
-bool DeveloperPrivateEnableFunction::RunImpl() {
+bool DeveloperPrivateEnableFunction::RunSync() {
scoped_ptr<Enable::Params> params(Enable::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
@@ -850,7 +849,7 @@ void DeveloperPrivateEnableFunction::OnRequirementsChecked(
DeveloperPrivateEnableFunction::~DeveloperPrivateEnableFunction() {}
-bool DeveloperPrivateInspectFunction::RunImpl() {
+bool DeveloperPrivateInspectFunction::RunSync() {
scoped_ptr<developer::Inspect::Params> params(
developer::Inspect::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get() != NULL);
@@ -1296,7 +1295,7 @@ void DeveloperPrivateChoosePathFunction::FileSelectionCanceled() {
DeveloperPrivateChoosePathFunction::~DeveloperPrivateChoosePathFunction() {}
-bool DeveloperPrivateIsProfileManagedFunction::RunImpl() {
+bool DeveloperPrivateIsProfileManagedFunction::RunSync() {
SetResult(new base::FundamentalValue(GetProfile()->IsManaged()));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698