Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4877)

Unified Diff: chrome/browser/extensions/api/context_menus/context_menus_api.cc

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bookmarks Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/context_menus/context_menus_api.cc
diff --git a/chrome/browser/extensions/api/context_menus/context_menus_api.cc b/chrome/browser/extensions/api/context_menus/context_menus_api.cc
index e9e7f76f27c32be82b4c2eddd9d70f0c522fd682..b1cef3377f04b67d079a7bb3877e9341b1c9424c 100644
--- a/chrome/browser/extensions/api/context_menus/context_menus_api.cc
+++ b/chrome/browser/extensions/api/context_menus/context_menus_api.cc
@@ -32,7 +32,7 @@ namespace Create = api::context_menus::Create;
namespace Remove = api::context_menus::Remove;
namespace Update = api::context_menus::Update;
-bool ContextMenusCreateFunction::RunImpl() {
+bool ContextMenusCreateFunction::RunSync() {
MenuItem::Id id(GetProfile()->IsOffTheRecord(),
MenuItem::ExtensionKey(extension_id()));
scoped_ptr<Create::Params> params(Create::Params::Create(*args_));
@@ -57,7 +57,7 @@ bool ContextMenusCreateFunction::RunImpl() {
GetExtension(), id, &error_);
}
-bool ContextMenusUpdateFunction::RunImpl() {
+bool ContextMenusUpdateFunction::RunSync() {
MenuItem::Id item_id(GetProfile()->IsOffTheRecord(),
MenuItem::ExtensionKey(extension_id()));
scoped_ptr<Update::Params> params(Update::Params::Create(*args_));
@@ -74,7 +74,7 @@ bool ContextMenusUpdateFunction::RunImpl() {
GetExtension(), item_id, &error_);
}
-bool ContextMenusRemoveFunction::RunImpl() {
+bool ContextMenusRemoveFunction::RunSync() {
scoped_ptr<Remove::Params> params(Remove::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
@@ -103,7 +103,7 @@ bool ContextMenusRemoveFunction::RunImpl() {
return true;
}
-bool ContextMenusRemoveAllFunction::RunImpl() {
+bool ContextMenusRemoveAllFunction::RunSync() {
MenuManager* manager = MenuManager::Get(GetProfile());
manager->RemoveAllContextItems(MenuItem::ExtensionKey(GetExtension()->id()));
manager->WriteToStorage(GetExtension(),
« no previous file with comments | « chrome/browser/extensions/api/context_menus/context_menus_api.h ('k') | chrome/browser/extensions/api/cookies/cookies_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698