chrome/browser/extensions/api/sessions/sessions_api.cc - Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sessions/sessions_api.cc

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bookmarks Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sessions/sessions_api.h ('k') | chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sessions/sessions_api.cc

diff --git a/chrome/browser/extensions/api/sessions/sessions_api.cc b/chrome/browser/extensions/api/sessions/sessions_api.cc

index 6ad2d90d97726af94009e168936d49a99339cd77..1b7fc2d60d0e66bd22ebcf71513d7b113b350b28 100644

--- a/chrome/browser/extensions/api/sessions/sessions_api.cc

+++ b/chrome/browser/extensions/api/sessions/sessions_api.cc

@@ -195,7 +195,7 @@ scoped_ptr<api::sessions::Session>

window.Pass());

}

-bool SessionsGetRecentlyClosedFunction::RunImpl() {

+bool SessionsGetRecentlyClosedFunction::RunSync() {

scoped_ptr<GetRecentlyClosed::Params> params(

GetRecentlyClosed::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params);

@@ -362,7 +362,7 @@ scoped_ptr<api::sessions::Device> SessionsGetDevicesFunction::CreateDeviceModel(

return device_struct.Pass();

}

-bool SessionsGetDevicesFunction::RunImpl() {

+bool SessionsGetDevicesFunction::RunSync() {

ProfileSyncService* service =

ProfileSyncServiceFactory::GetInstance()->GetForProfile(GetProfile());

if (!(service && service->GetPreferredDataTypes().Has(syncer::SESSIONS))) {

@@ -564,7 +564,7 @@ bool SessionsRestoreFunction::RestoreForeignSession(const SessionId& session_id,

return SetResultRestoredWindow(ExtensionTabUtil::GetWindowId(browsers[0]));

}

-bool SessionsRestoreFunction::RunImpl() {

+bool SessionsRestoreFunction::RunSync() {

scoped_ptr<Restore::Params> params(Restore::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params);