chrome/browser/extensions/api/history/history_api.cc - Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/history/history_api.cc

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bookmarks Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/history/history_api.h ('k') | chrome/browser/extensions/api/hotword_private/hotword_private_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/history/history_api.cc

diff --git a/chrome/browser/extensions/api/history/history_api.cc b/chrome/browser/extensions/api/history/history_api.cc

index cd216a148db7d34a287b738794027f1981b84aab..51670d2b8d93f2eac362d469ae6fee29b1547a68 100644

--- a/chrome/browser/extensions/api/history/history_api.cc

+++ b/chrome/browser/extensions/api/history/history_api.cc

@@ -235,12 +235,6 @@ void HistoryAPI::OnListenerAdded(const EventListenerInfo& details) {

EventRouter::Get(browser_context_)->UnregisterObserver(this);

}

-void HistoryFunction::Run() {

- if (!RunImpl()) {

- SendResponse(false);

- }

bool HistoryFunction::ValidateUrl(const std::string& url_string, GURL* url) {

GURL temp_url(url_string);

if (!temp_url.is_valid()) {