Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: extensions/browser/extension_function.h

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bookmarks Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/test/test_api.cc ('k') | extensions/browser/extension_function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_function.h
diff --git a/extensions/browser/extension_function.h b/extensions/browser/extension_function.h
index ee58cba589164fc150d057196fab2b6fdcb0890d..ee5f97a7c9dbe2f2ddde7e9849cb81b05e002b27 100644
--- a/extensions/browser/extension_function.h
+++ b/extensions/browser/extension_function.h
@@ -120,11 +120,11 @@ class ExtensionFunction
// Execute the API. Clients should initialize the ExtensionFunction using
// SetArgs(), set_request_id(), and the other setters before calling this
- // method. Derived classes should be ready to return GetResultList() and
- // GetError() before returning from this function.
+ // method.
+ //
// Note that once Run() returns, dispatcher() can be NULL, so be sure to
// NULL-check.
- virtual void Run();
+ void Run();
// Gets whether quota should be applied to this individual function
// invocation. This is different to GetQuotaLimitHeuristics which is only
@@ -502,9 +502,11 @@ class SyncExtensionFunction : public UIThreadExtensionFunction {
public:
SyncExtensionFunction();
- virtual void Run() OVERRIDE;
+ virtual bool RunImpl() OVERRIDE;
protected:
+ virtual bool RunSync() = 0;
+
virtual ~SyncExtensionFunction();
};
@@ -512,9 +514,11 @@ class SyncIOThreadExtensionFunction : public IOThreadExtensionFunction {
public:
SyncIOThreadExtensionFunction();
- virtual void Run() OVERRIDE;
+ virtual bool RunImpl() OVERRIDE;
protected:
+ virtual bool RunSync() = 0;
+
virtual ~SyncIOThreadExtensionFunction();
};
« no previous file with comments | « extensions/browser/api/test/test_api.cc ('k') | extensions/browser/extension_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698