chrome/browser/extensions/api/preference/preference_api.cc - Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/preference_api.cc

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bookmarks Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.h ('k') | chrome/browser/extensions/api/principals_private/principals_private_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/preference_api.cc

diff --git a/chrome/browser/extensions/api/preference/preference_api.cc b/chrome/browser/extensions/api/preference/preference_api.cc

index 26a088fb5ec006a06bfa9fa00df18c24b6d4a57a..2f9d89eeecbd5710c0967725f7ec12cf7f160dfb 100644

--- a/chrome/browser/extensions/api/preference/preference_api.cc

+++ b/chrome/browser/extensions/api/preference/preference_api.cc

@@ -521,7 +521,7 @@ bool PreferenceFunction::ValidateBrowserPref(

GetPreferenceFunction::~GetPreferenceFunction() { }

-bool GetPreferenceFunction::RunImpl() {

+bool GetPreferenceFunction::RunSync() {

std::string pref_key;

EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &pref_key));

base::DictionaryValue* details = NULL;

@@ -583,7 +583,7 @@ bool GetPreferenceFunction::RunImpl() {

SetPreferenceFunction::~SetPreferenceFunction() { }

-bool SetPreferenceFunction::RunImpl() {

+bool SetPreferenceFunction::RunSync() {

std::string pref_key;

EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &pref_key));

base::DictionaryValue* details = NULL;

@@ -669,7 +669,7 @@ bool SetPreferenceFunction::RunImpl() {

ClearPreferenceFunction::~ClearPreferenceFunction() { }

-bool ClearPreferenceFunction::RunImpl() {

+bool ClearPreferenceFunction::RunSync() {

std::string pref_key;

EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &pref_key));

base::DictionaryValue* details = NULL;